Skip to content

Sum::operator += IsSummationSimplifiable check: getCommonVars -> GCD - #632

Open
ohhmm wants to merge 1 commit into
mainfrom
add
Open

Sum::operator += IsSummationSimplifiable check: getCommonVars -> GCD#632
ohhmm wants to merge 1 commit into
mainfrom
add

Conversation

@ohhmm

@ohhmm ohhmm commented Dec 18, 2024

Copy link
Copy Markdown
Owner

No description provided.

@ohhmm
ohhmm force-pushed the add branch 5 times, most recently from ce005ce to 6889426 Compare February 16, 2025 09:40
@ohhmm
ohhmm force-pushed the add branch 3 times, most recently from e9e4ae6 to 8758cf8 Compare February 23, 2025 22:19
@ohhmm
ohhmm force-pushed the add branch 2 times, most recently from 820d8f4 to e1506dd Compare March 8, 2025 13:23
Comment thread omnn/math/Sum.cpp
@@ -805,68 +805,24 @@ namespace

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! The PR simplifies the Sum::operator+= method by removing complex optimization logic and replacing it with a more streamlined approach. This is a good improvement in code maintainability.

@ohhmm
ohhmm force-pushed the add branch 3 times, most recently from 8eb7e8b to 96c571a Compare March 16, 2025 09:45

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! The PR simplifies the Sum::operator+= method by removing complex optimization logic and replacing it with a more streamlined approach. This is a good improvement in code maintainability.

@ohhmm
ohhmm force-pushed the add branch 2 times, most recently from 7470a73 to 338f56b Compare March 20, 2025 13:43
@devin-ai-integration

Copy link
Copy Markdown
Contributor

Everything looks good! The PR simplifies the Sum::operator+= method by removing complex optimization logic and replacing it with a more streamlined approach. This is a good improvement in code maintainability.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! The PR simplifies the Sum::operator+= method by removing complex optimization logic and replacing it with a more streamlined approach. This is a good improvement in code maintainability.

@ohhmm
ohhmm force-pushed the add branch 4 times, most recently from 03e7830 to 2191cc7 Compare March 21, 2025 11:24
Comment thread omnn/math/Sum.cpp

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! The PR simplifies the Sum::operator+= method by removing complex optimization logic in favor of a more streamlined approach, which improves code maintainability.

Comment thread omnn/math/Sum.cpp

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! The PR simplifies the Sum::operator+= method by removing complex optimization logic in favor of a more streamlined approach, which improves code maintainability.

Comment thread omnn/math/Sum.cpp
}
auto AddTheValue = [&,this]() -> Valuable& {
if (add.is_optimized())
auto& value = addOptimizedValue ? add : *optimizedValue;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! The PR simplifies the Sum::operator+= method by removing complex optimization logic in favor of a more streamlined approach, which improves code maintainability.

@ohhmm
ohhmm force-pushed the add branch 2 times, most recently from 76ffa47 to 89cb9c6 Compare March 29, 2025 20:21
Comment thread omnn/math/Sum.cpp
operator+=(add.as<Sum>());
}
else if (optimizations)
if (optimizations)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! The PR simplifies the Sum::operator+= method by removing complex optimization logic in favor of a more streamlined approach, which improves code maintainability. The changes maintain the same functionality while making the code more readable and easier to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant