Repository navigation
fix: memoise n1 query - #74
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix
What is deliberately not cached
Feature access. A handler decides it, and it can flip between two checks without touching the model, so checkFeatureAccess() runs before the memo is consulted on every call. Caching across it broke three FeatureIntegrationTest cases in an early attempt. $bypassFeatureCheck is not part of the cache key because that check is the only thing it affects.
Invalidation
Risk
This changes the path every authorization check takes, so review it as a security change rather than a performance change. The key question is whether a stale true is reachable—the answer depends on the invalidation list above being complete and feature access staying outside the cache.
Verification