fix(settings): show Google email OAuth callback results#5654
Open
RaresKeY wants to merge 1 commit into
Open
Conversation
3 tasks
RaresKeY
marked this pull request as ready for review
July 21, 2026 12:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Open Settings directly to Integrations after a Google OAuth callback and show the existing success/error banner once the document is ready. The redirect handler now calls this module's own
open()API instead of polling forever for a window-level alias that is never assigned.The callback query parameters are still removed from browser history before the result is displayed. No new component or style system is introduced.
Target branch
dev, notmain.Linked Issue
Fixes #5643
Part of #5637
Type of Change
Checklist
dev.How to Test
Run:
Complete or simulate a callback redirect containing
email_oauth_success=1.Verify Settings opens to Integrations once and shows the success banner.
Repeat with
email_oauth_error=...and verify the error banner appears.Reload and verify the cleaned URL does not replay either banner.
Current-
devisolated validation passes 17 focused/adjacent tests, JavaScript syntax, and diff checks. A running-app browser pass also verifies that Integrations opens, the success banner appears, and the callback query is removed.Visual / UI changes — REQUIRED if you touched anything that renders
The existing Settings panel and callback result banner now appear after redirect. Their current visual styling is retained.
Screenshots / clips
Running-app capture using a synthetic success query; no credentials or live provider traffic: