fix(settings): preserve the OAuth connect payload#5652
Open
RaresKeY wants to merge 1 commit into
Open
Conversation
3 tasks
RaresKeY
marked this pull request as ready for review
July 21, 2026 12:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve the selected SMTP security mode and display name when the Email tab's
Google Connect button first saves an account. This keeps the saved SMTP port
and security mode consistent instead of relying on a server-side default that
can disagree with the form.
The change only adds two existing form values to the account payload. It does
not change rendering, account layout, or the OAuth redirect flow.
Target branch
dev, notmain.Linked Issue
Fixes #5647
Part of #5637
Type of Change
Checklist
dev.How to Test
Run:
In the Email account form, select SMTP port 587 with STARTTLS and enter a display name.
Click Connect with Google and inspect the account-creation request.
Verify
smtp_securityanddisplay_namematch the form and persist on the saved account.Current-
devisolated validation passes 37 focused/adjacent tests, JavaScript syntax, and diff checks.Visual / UI changes
N/A — the existing form renders identically; only its request payload changes.
Screenshots / clips
N/A — no visual rendering change.