fix(email): hide OAuth storage fields from config responses#5651
Merged
o3LL merged 1 commit intoJul 22, 2026
Conversation
3 tasks
RaresKeY
marked this pull request as ready for review
July 21, 2026 12:20
o3LL
approved these changes
Jul 22, 2026
o3LL
left a comment
Collaborator
There was a problem hiding this comment.
Correct, minimal, and complete! Approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove encrypted Google OAuth access-token, refresh-token, and expiry storage fields from the browser-facing legacy email configuration response. The route still returns the provider status and ordinary account settings needed by the UI, matching the existing account-list response boundary.
The internal transport helper remains unchanged and can continue supplying OAuth fields to server-side IMAP/SMTP callers.
Target branch
dev, notmain.Linked Issue
Fixes #5639
Part of #5637
Type of Change
Checklist
dev.How to Test
Run:
Configure a Google email account and request
GET /api/email/config.Verify the response still contains
oauth_provider: "google"but does not containoauth_access_token,oauth_refresh_token, oroauth_token_expiry.Verify password masking and ordinary email preferences are unchanged.
Current-
devisolated validation passes 146 adjacent tests. Python compilation and diff checks pass.Visual / UI changes
N/A — backend response serialization and tests only; no UI rendering changed.
Screenshots / clips
N/A — no visual changes.