fix(reminders): support OAuth SMTP accounts#5649
Merged
o3LL merged 1 commit intoJul 22, 2026
Merged
Conversation
3 tasks
RaresKeY
marked this pull request as ready for review
July 21, 2026 12:20
o3LL
approved these changes
Jul 22, 2026
o3LL
left a comment
Collaborator
There was a problem hiding this comment.
Approved!
I just want to mention that the How-to-Test command lists tests/test_note_reminder_email.py, which doesn't exist pytest aborts on the missing path, so the command fails as written (the real adjacent suites are test_note_reminder_fire_scope.py etc.).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow email reminders to use a saved Google OAuth SMTP account without a stored SMTP password. Backend account selection now uses the shared SMTP-ready contract, and the Settings reminder selector treats either a saved password or Google OAuth as valid SMTP credentials.
Password accounts and same-owner fallback selection keep their existing behavior. The change is intentionally limited to reminder readiness; SMTP sending remains owned by the existing email transport helper.
Target branch
dev, notmain.Linked Issue
Fixes #5642
Part of #5637
Type of Change
Checklist
dev.How to Test
Run:
Save a Google OAuth account with SMTP host/user and no SMTP password.
Select it for an email reminder and verify it appears as configured.
Dispatch the reminder and verify the shared SMTP helper receives the selected OAuth account.
Repeat with a password account and verify existing behavior is unchanged.
Current-
devisolated validation passes 38 focused/adjacent tests, JavaScript syntax, and diff checks. A running-app browser pass also verifies the reminder panel, Email channel, and selected OAuth-only SMTP account. Live SMTP remains a reviewer item.Visual / UI changes — REQUIRED if you touched anything that renders
The existing reminder account selector can now include Google OAuth SMTP accounts. No layout, style, spacing, or component pattern changed.
Screenshots / clips
Running-app capture using a synthetic local Google OAuth account; no credentials or live provider traffic: