fix(compare): lift z-index of model-picker-wrap when picker is open#5541
Open
CodeRulerNo1 wants to merge 2 commits into
Open
fix(compare): lift z-index of model-picker-wrap when picker is open#5541CodeRulerNo1 wants to merge 2 commits into
CodeRulerNo1 wants to merge 2 commits into
Conversation
…o prevent rendering under compare/tool overlays
…y stacking context
77d5b56 to
bf406b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the Compare setup modal (
#compare-model-overlay) is open, clicking the main model picker button in the chat box opens the model picker dropdown menu (#model-picker-menu) behind/underneath the Compare setup modal.This happens because the
.chat-input-barcontainer usescontainer-type: inline-size;(for container queries), which creates a locked stacking context under CSS containment rules. This traps anyz-indexof the model picker inside the input bar.This PR fixes the issue by dynamically elevating the entire
.chat-input-bar's z-index and position (position: relative; z-index: topPortalZ()) when the model picker is opened and restoring it when closed, allowing the menu to correctly render on top of the modal.Target branch
dev, notmain. All PRs land indev;mainis curated by the maintainer at each release. If your PR is onmainby accident, click "Edit" on this PR and change the base.Linked Issue
Fixes #5542
Type of Change
Checklist
devdocker compose uporuvicorn app:app) and verified the change works end-to-end. Type-checks and unit tests are not enough.How to Test
.chat-input-bar's position and z-index return to normal.Visual / UI changes — REQUIRED if you touched anything that renders
Anything that changes what the UI looks like — buttons, icons, padding, colors, fonts, spacing, layout, CSS, HTML, SVG, or any
static/js/module that draws to the DOM — needs all of the following. PRs that change rendering without these WILL be closed.--red,--fg,--bg,--card,--border, etc.) — do not introduce new color values, font sizes, or spacing units.static/index.html) or plain text.Fira Code) for primary UI text. Don't override.Screenshots / clips
None (pure stacking-context layer issue fix, layout structure and visual styles remain identical).