Skip to content

fix(research): respect disabled web access#5539

Open
alvin-cmd wants to merge 1 commit into
odysseus-dev:devfrom
alvin-cmd:fix/block-research-when-web-disabled-5527
Open

fix(research): respect disabled web access#5539
alvin-cmd wants to merge 1 commit into
odysseus-dev:devfrom
alvin-cmd:fix/block-research-when-web-disabled-5527

Conversation

@alvin-cmd

@alvin-cmd alvin-cmd commented Jul 15, 2026

Copy link
Copy Markdown

Summary

The web toggle only denied web_search and web_fetch, so the agent could still call trigger_research and reach the internet through a research job. This change adds trigger_research to the per-turn denylist when web access is off, while keeping explicitly requested research available. Regression tests cover both cases.

Target branch

  • This PR targets dev, not main.

Linked Issue

Fixes #5527

Type of Change

  • Bug fix (non-breaking, fixes a confirmed issue)
  • New feature
  • Breaking change
  • Refactor / cleanup
  • Documentation only
  • CI / tooling / configuration

Checklist

  • I searched open issues and open PRs. This is not a duplicate.
  • This PR targets dev.
  • My changes are limited to the issue. There are no unrelated refactors or whitespace changes.
  • I ran the full app with Docker or Uvicorn. This policy-only change was verified with focused automated tests instead.

How to Test

  1. Check out this branch in an existing Odysseus development environment.

  2. Run the focused policy and research tests:

    python -m pytest tests/test_chat_route_tool_policy.py tests/test_tool_policy.py tests/test_research_chat_stream_owner.py -q
  3. Confirm the suite reports 42 passing tests. The regression cases verify that trigger_research is denied when web access is off and remains available when research is explicitly enabled.

Visual / UI changes

Not applicable. This PR does not change CSS, HTML, SVG, or frontend JavaScript.

@github-actions github-actions Bot added needs work PR description incomplete — please update before review ready for review Description complete — ready for maintainer review and removed needs work PR description incomplete — please update before review labels Jul 15, 2026
@alvin-cmd alvin-cmd marked this pull request as ready for review July 15, 2026 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review Description complete — ready for maintainer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Agent bypasses "web search off" via trigger_research — research tool is not treated as a web tool

1 participant