refactor(recorder): extract chunk transcriber#23
Merged
Conversation
- Keep the collector ticker loop thin around poll orchestration. - Move speaker polling side effects behind a focused collector type. - Cover participant, meeting, timeline, and error handling paths.
- Move per-chunk transcription orchestration out of Recorder. - Preserve system-first emission, mic dedup fallback, and error logging. - Add focused coverage for chunk transcription state and errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChunkTranscriberto own per-chunk sys/mic transcription and emission.Recorderresponsible for lifecycle side effects: signal flush, append, segmenter feed, and logging.Test plan
go test ./internal/recorder ./internal/speechmise run testmise run build