Master style fix ged#1971
Merged
Merged
Conversation
updateStyle only re-applies style properties whose string value changed. This is unsafe with CSS shorthands: re-setting a shorthand (e.g. `background`, `margin`) resets the longhands it covers, so a following longhand override with an unchanged value would be skipped by the diff and silently clobbered. For instance, `background: <dynamic>; background-color: red;` would lose its red background-color whenever the dynamic part changed. Fix: once any property has been re-applied, re-apply every following property too (declaration order), matching a fresh setStyle.
ged-odoo
force-pushed
the
master-style-fix-ged
branch
from
1fbf0be to
37020e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.