[FIX] owl-core: add .toShape() to reuse a schema as props#1967
Merged
Conversation
Passing a composed schema (e.g. `t.and([...])` or `t.object({...})`) to
`props()` failed validation with a spurious `missingKeys: ["optional"]`
error: a validator is a function carrying an `.optional` method, so
`props()` mistook it for a plain `{key: Type}` shape and `Object.keys`
returned `["optional"]`.
Rather than teach `props()` to unwrap a validator, object schemas
(`t.object`, `t.strictObject`) and intersections of them (`t.and`) now
expose a `.toShape()` method returning the `{key: type}` map they were
built from (`t.and` merges the shapes of its members). `props()` is left
unchanged; a reusable schema drives props via `props(Schema.toShape())`,
e.g. `applyDefaults(props(Schema.toShape()), Schema)`.
closes #1966
ged-odoo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing a composed schema (e.g.
t.and([...])ort.object({...})) toprops()failed validation with a spuriousmissingKeys: ["optional"]error: a validator is a function carrying an.optionalmethod, soprops()mistook it for a plain{key: Type}shape andObject.keysreturned["optional"].Rather than teach
props()to unwrap a validator, object schemas (t.object,t.strictObject) and intersections of them (t.and) now expose a.toShape()method returning the{key: type}map they were built from (t.andmerges the shapes of its members).props()is left unchanged; a reusable schema drives props viaprops(Schema.toShape()), e.g.applyDefaults(props(Schema.toShape()), Schema).closes #1966