fix(rest-api): fix REST route initialization and secure verify callback against IDOR vulnerability - #1
Open
schinowski wants to merge 2 commits into
Open
fix(rest-api): fix REST route initialization and secure verify callback against IDOR vulnerability#1schinowski wants to merge 2 commits into
schinowski wants to merge 2 commits into
Conversation
Signed-off-by: schinowski <sebastian@puffercode.com>
Signed-off-by: schinowski <sebastian@puffercode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR resolves one issue and one vulnerability within the REST API initialization and verification flows:
register_rest_routehook out of the gateway constructor to ensure it executes reliably during therest_api_initlifecycle hook. This resolvesrest_no_routeerrors on redirection that I encountered on a fresh installation.key(order_key) validation to the verification endpoint to prevent unauthorised order ID enumeration.wp_nonce_urlHTML escaping inreturnUrl, preventing&from being turned into&, which was causing parameter parsing failures.