fix stealth range proofs threading and amount parse crashes - #13
Open
mooncitydev wants to merge 1 commit into
Open
fix stealth range proofs threading and amount parse crashes#13mooncitydev wants to merge 1 commit into
mooncitydev wants to merge 1 commit into
Conversation
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hey, was reading the stealth send path and noticed the two pvac_make_range_proof calls were fired on worker threads while both used the same g_pvac pk/sk handles. pretty sure libpvac is not meant to be entered concurrently on one keypair (native code, scratch buffers, who knows). easiest safe fix is to run the two proofs back to back like everything else in that handler.
also wrapped parse_amount_raw in a catch for stoll failures. huge digit strings or other junk could throw and bubble out as a 500 instead of a normal invalid amount response.
cheers