Repository navigation
Conversation
Settings version 10 adds a window line after the ceilings. It is read before the window opens, so a saved fullscreen starts fullscreen and leaving it returns to the saved windowed size and place. Version 9 files read as windowed at the default size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #309
Plan: boom 0.50.0 (window_bounds, window_open_placed, Config.position). Settings version 10 adds a window line (mode, position flag, x, y, width, height) after the ceilings.
config.load_framereads it before the window opens, so a saved fullscreen starts fullscreen with no windowed flash.on_dnitsaveswindow_modeandwindow_bounds. Version 9 files read as windowed at the default size. Bench and capture runs open the default window.Ran: full
mach test .under a headless kwin, plus the config tests again after the final fix.