Repository navigation
feat(team): Team member expert fields (J3, #231) - #292
Merged
Merged
Conversation
Verbatim copies of every team/*.md file of ocobo-revops/posts (main b34a449).
Mirror ocobo-revops/posts#95: optional challenge, contribution (fr and en), tools (ordered Tool slugs) and previousCompanies. contribution and tools are required when challenge is set. Same caps, regexes and messages as the posts schema. No quote field: bio stays the about-us text. Tests validate every posts team file and cover each expert field rule.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #231
What
MemberFrontmatterSchemainapp/modules/schemas.tsgains the four optional expert fields of ocobo-revops/posts#95 (merged as ocobo-revops/posts#108):challenge: one ofCHALLENGE_KEYS(imported fromapp/modules/challenge-schema.ts, not edited).contribution:{ fr, en }, each at most 100 characters, blank rejected.tools: 1 to 8 unique Tool slugs, order kept.previousCompanies: 1 to 3 names, each at most 30 characters, blank rejected.If
challengeis set,contributionandtoolsare required. Caps, regexes and error messages are the same asscripts/schemas/team-member.schema.jsin posts. There is noquotefield;biostays the about-us text. No consumer changes:PersonCardwiring belongs to #232.Tests
app/test/fixtures/content/team/: verbatim copies of the 19 poststeam/*.mdfiles (posts main b34a449). Each one validates.app/modules/member-schema.test.ts: a file with all four fields validates;challengewithoutcontributionor withouttoolsfails with an issue at that path; caps, duplicates, blanks and ordering.pnpm check,pnpm typecheck,pnpm test:run(743 tests) green. Code review done; its findings are fixed.Not done
docs/api/data-models.mddoes not describe Team members, so it is unchanged.track, the website requiresarchitect | builder | expert-engineer. A posts file with another track would pass posts CI and fail the website.