Repository navigation
refactor(tokens): rename enjeu colour tokens to challenge - #263
Merged
Merged
Conversation
Rename the enjeu.* semantic colour tokens and their .light tints to challenge.*, with their call sites, comments, the navbar v2 test and the docs. French UI strings and the French route segment are unchanged. Closes #262
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the code term
enjeutochallengein the website. The content repo already made the same rename (ocobo-revops/posts#108, #109, #111).enjeu.{rp,se,sc,cx,sy,ai}and their.lighttints becomechallenge.*inpreset/semantic-tokens.ts.app/components/design-system/flip-card-section.tsxandapp/components/design-system/v2-tokens-section.tsx. The design system section title becomes "Challenge colours".preset/slot-recipes/flip-card.ts,app/modules/bowtie-stages.tsandapp/components/navbar-v2/.challenges. The French label "Vos enjeux" and the French path/fr/enjeux/rpstay.CLAUDE.md, ADR 0002, the component inventory and the J1 route review checklist.Unchanged on purpose: French UI strings (
locales/fr/*, the French demo copy "Enjeu 01" on the flip card showcase) and the six keys.locales/encontained no "Enjeu", so it needed no change.Issues #227, #229, #230, #232 to #237, #241 and #243 were retitled to say "challenge". The other issues under #212 had no enjeu in their title. The bodies of #227, #229 to #239 and #241 to #243 now say challenge too, including
fetchChallenge,challenges/<lang>/and thechallengeteam member field.git grep -i enjeu -- app presetnow returns only French UI strings.Open question: English route segment
French pages stay at
/enjeux/<slug>. Which segment do English pages use?/en/challenges/<slug>(proposed): matches the English label and the content directory. Needs a slug mapping inapp/utils/redirections.ts./en/enjeux/<slug>: one segment for both languages, simpler routing, but a French word in English URLs.This PR changes no route. The answer feeds #233 (J4: challenge page route with hero, symptoms, audience and diagnostic).
Review on the Vercel preview
/design-system: the "Challenge colours" section shows the six accents and tints as before, and the flip card pill keeps its mint.This PR changes a shared preset token. Pages not being redesigned that it can alter: none use the renamed tokens (offer, blog, customer stories, legal and contact have no
enjeu.*call site).Checks
pnpm check,pnpm typecheck: green.pnpm test:run: 41 files, 490 tests pass.Closes #262