Repository navigation
ready adapter - #4
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7293fa77c4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| def is_demo_run(manifest: dict, spec: dict) -> bool: | ||
| mode = (((manifest.get("inputs") or {}).get("algorithm") or {}).get("mode")) | ||
| return mode == "demo" or spec.get("adapter_type") == "demo_only" |
There was a problem hiding this comment.
When a generated skill has adapter_type: demo_only and the user supplies a non-demo manifest such as inputs.algorithm.mode: run, this condition still treats the invocation as a demo run, skips the adapter-not-ready blocking path, and writes a passing demo summary. That contradicts the new non-demo blocking semantics and can make a requested user-data run appear successful even though no real adapter exists.
Useful? React with 👍 / 👎.
No description provided.