Add some checks on .install root and rootexec fields - #7039
Draft
rjbou wants to merge 6 commits into
Draft
Conversation
2 tasks
…y paths target without using '..' Co-authored-by: Raja Boujbel <raja.boujbel@ocamlpro.com>
rjbou
force-pushed
the
dot-install-root-checks
branch
from
July 15, 2026 17:47
d8ef23f to
be6cbbf
Compare
Member
|
I would argue that having this check would be at best unnecessary and at worst annoying for users generating their .install file themselves. I can honestly see value in giving users the possibility to simply do: it would make protyping a lot easier for small tools and scripts (e.g. generating opam packages from other package managers) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some checks on the target optional field : it shouldn't begin with another field prefix. There a warning when it is the case (and failure on strict mode)
From #6938 (comment)
Todo :
Pp.warnwith an optional argument to not display warning only on verbose moderootandrootexecsections to .install files #6938