Update argument definitions with cmdliner completion functions - #6868
Open
WardBrian wants to merge 10 commits into
Open
Update argument definitions with cmdliner completion functions#6868WardBrian wants to merge 10 commits into
WardBrian wants to merge 10 commits into
Conversation
WardBrian
force-pushed
the
cmdliner-completion
branch
from
April 23, 2026 15:45
64410a0 to
3d342b1
Compare
WardBrian
force-pushed
the
cmdliner-completion
branch
from
July 23, 2026 20:50
3d342b1 to
7965497
Compare
WardBrian
force-pushed
the
cmdliner-completion
branch
from
July 24, 2026 13:39
7965497 to
0956610
Compare
WardBrian
force-pushed
the
cmdliner-completion
branch
from
July 24, 2026 14:01
0956610 to
2eed079
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is patch 3/4 in a sequence for improving the opam completion and adding powershell support.
Previous: #6854 updates the opam source for compatibility with cmdliner 2.1.0, #6867 actually updates the vendored cmdliner
This PR: Updates the arg definitions in opamClient to provide completion functions for all of opam's custom argument types.
This patch breaks down into three pieces:
opamlist_columnsthat just return a list of optionspackage_completionmk_subcommands/mk_subcommands_with_defaultthat allows for completion of both subcommand names and the arguments for them.The completions provided by this PR are more complete and correct than those in the current completion script.
They can be tested with
Comparison
Up next: Final PR updating the build system to replace existing completion scripts and add powershell completions.