Allow moving a file to a directory with the same name (and vice-versa) in opam repositories - #6779
Draft
kit-ty-kate wants to merge 1 commit into
Draft
Allow moving a file to a directory with the same name (and vice-versa) in opam repositories#6779kit-ty-kate wants to merge 1 commit into
kit-ty-kate wants to merge 1 commit into
Conversation
…anging to a directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3830
#5892 allows us to implement this, however it is a corner-case that wasn't supported before so i chose to not implement it at the time. It instead now at least show a proper error message.
It might be interesting to implement it in the future to avoid breaking users if issues such as the one described in #3830 happened again.
TODO:
OpamRepositoryBackend)OpamRepositoryBackend, this one is a quite a bit more complicated as it involves checking that the directory doesn't contain other files that aren't moved too and moving them at the same time if so)