Enforce dry run not changing opam root - #6565
Conversation
rjbou
changed the title
|
I added several tests in the PR, all are fixed. I'm looking for other tests to add, even if they are not fixed in this PR. |
| match OpamStateConfig.(!r.dryrun), result with | ||
| | true, Result () -> | ||
| let base f = OpamFilename.Base.of_string (OpamFilename.Dir.to_string f) in | ||
| (match OpamRepositoryBackend.get_diff (OpamFilename.Dir.of_string "/") (base srcdir) (base srcdir0) with |
There was a problem hiding this comment.
temporary hack, get_diff needs to change arguments and take absolute path, or have 2 functions.
| let srcdir = OpamPath.Switch.pinned_package root st.switch nv.name in | ||
| let srcdir = | ||
| if OpamStateConfig.(!r.dryrun) then | ||
| OpamFilename.mk_tmp_dir () |
There was a problem hiding this comment.
i didn't check if all these temp dir created are well cleaned
rjbou
added
the
PR: QUEUED
|
Does this also fix #6492 ? |
|
Per 2025/09/08 dev meeting: we don't need to split this PR up. The remaining thing to do is to move the API change to another PR, to add some more tests and figure out what needs to be done with |
2 participants
No description provided.