Skip to content

Make it so pin list display the current revision of the pinned repo - #6274

Merged
rjbou merged 2 commits into
ocaml:masterfrom
desumn:master
Nov 27, 2024
Merged

Make it so pin list display the current revision of the pinned repo#6274
rjbou merged 2 commits into
ocaml:masterfrom
desumn:master

Conversation

@desumn

@desumn desumn commented Oct 28, 2024

Copy link
Copy Markdown
Contributor

Implementation of issue #5533

It works, but I'm not sure it's the best way to do it

@desumn

desumn commented Oct 28, 2024

Copy link
Copy Markdown
Contributor Author

In particular, may the url or revision be empty for a git/hs/darcs kind?

@rjbou
rjbou requested review from kit-ty-kate and rjbou October 29, 2024 09:46

@rjbou rjbou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for you PR!
You'll find some comments specific to the implementation the implementation.
To complete the PR, it needs also to:

  • add a test (we can do it)
  • update the list manpage text to inform about the new column, especially that it is the hash of the current state of the source, not the installed one.
  • polishing (remove trailing whitespace, indent, 80 columns), but we will do it at the end.

A todo for the dev team: we'll need to add a more exhaustive test to pin, existing one tests only the several kind of pin (vcs/path/version), but not the not synchronised package.

Comment thread src/client/opamPinCommand.ml Outdated
Comment thread src/client/opamPinCommand.ml Outdated
Comment thread master_changes.md Outdated
Comment thread src/client/opamPinCommand.ml Outdated
Comment thread src/client/opamPinCommand.ml Outdated
Comment thread src/client/opamPinCommand.ml Outdated
Comment thread src/client/opamPinCommand.ml Outdated
Comment thread src/client/opamPinCommand.ml Outdated
@kit-ty-kate kit-ty-kate added this to the 2.4.0~alpha1 milestone Oct 29, 2024
@kit-ty-kate

Copy link
Copy Markdown
Member

side remark on the code itself: many of the lines of code added by this PR contain a trailing whitespace. It would be nice to avoid them

@desumn

desumn commented Oct 29, 2024

Copy link
Copy Markdown
Contributor Author

Thanks for your review, I'll be working on implementing them

@kit-ty-kate kit-ty-kate left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks for this contribution!
We'll do the rest (fix the tests)

@kit-ty-kate
kit-ty-kate requested a review from rjbou October 29, 2024 20:15
@rjbou

rjbou commented Nov 26, 2024

Copy link
Copy Markdown
Collaborator

Discussed on dev meeting: We end up converging to this syntax
image

Comment thread .github/scripts/main/main.sh Outdated

@rjbou rjbou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants