Skip to content

Add amlc-lsp.0.2.0 - #30622

Open
chris-in-the-shell wants to merge 6 commits into
ocaml:masterfrom
chris-in-the-shell:add-amlc-lsp-0.1.0
Open

Add amlc-lsp.0.2.0#30622
chris-in-the-shell wants to merge 6 commits into
ocaml:masterfrom
chris-in-the-shell:add-amlc-lsp-0.1.0

Conversation

@chris-in-the-shell

@chris-in-the-shell chris-in-the-shell commented Sep 3, 2026

Copy link
Copy Markdown

Summary

Adds amlc-lsp 0.2.0, a language server for AML and Octra AppliedML.

Source

Validation

  • opam lint passes for the package definition.
  • The upstream project's native OPAM build-and-test workflow passes on Linux and macOS.
  • Windows CI passes for both MSYS2 and Cygwin.

Comment thread packages/amlc-lsp/amlc-lsp.0.1.0/url Outdated
Comment thread packages/amlc-lsp/amlc-lsp.0.2.0/opam Outdated
depends: [
"ocaml" {>= "4.14"}
"dune" {>= "3.16"}
"yojson"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, much better now!

The lower bounds checks are catching that this isn't building with all yojson versions, so you need to add a lower bound:

lower-bounds (failed: Unbound type constructor Yojson.Safe.t)

=== downgrade 2 packages
  - downgrade dune          3.24.2 to 3.18.2 [required by amlc-lsp]
  - downgrade yojson        3.0.0 to 1.5.0   [required by amlc-lsp]

[...]

#=== ERROR while compiling amlc-lsp.0.2.0 =====================================#
# context              2.6.0~beta1 | linux/x86_64 | ocaml-base-compiler.5.5.0 | pinned(https://github.com/arkenstone-lab/amlc-lsp/archive/refs/tags/v0.2.0.tar.gz)
# path                 ~/.opam/5.5/.opam-switch/build/amlc-lsp.0.2.0
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p amlc-lsp -j 255
# exit-code            1
# env-file             ~/.opam/log/amlc-lsp-7-3c37eb.env
# output-file          ~/.opam/log/amlc-lsp-7-3c37eb.out
### output ###
# (cd _build/default && /home/opam/.opam/5.5/bin/ocamlc.opt -w -40 -g -bin-annot -bin-annot-occurrences -I lib/.amlc_lsp.objs/byte -I /home/opam/.opam/5.5/lib/biniou -I /home/opam/.opam/5.5/lib/camlp-streams -I /home/opam/.opam/5.5/lib/easy-format -I /home/opam/.opam/5.5/lib/ocaml/unix -I /home/opam/.opam/5.5/lib/yojson -no-alias-deps -o lib/.amlc_lsp.objs/byte/amlc_lsp.cmo -c -impl lib/amlc_lsp.ml)
# File "lib/amlc_lsp.ml", line 1596, characters 62-75:
# 1596 | let project_rename_imported uri text start name replacement : Yojson.Safe.t option =
#                                                                      ^^^^^^^^^^^^^
# Error: Unbound type constructor Yojson.Safe.t


@chris-in-the-shell chris-in-the-shell changed the title Add amlc-lsp.0.1.0 Add amlc-lsp.0.2.0 Sep 5, 2026
@chris-in-the-shell

Copy link
Copy Markdown
Author

Thanks! I've added yojson {>= "1.6.0"}, since Yojson.Safe.t was introduced in yojson 1.6.0. The updated lower-bounds check is now pending

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants