more flexible libcurl depext on debian/ubuntu - #30360
Conversation
|
Hmm, the tests show this does not always work without help of the user. |
|
It's probably better from a UI perspective to have two conf packages (which depend on the variants) and let the opam solver just pick one. A user can select a concrete one to override if they have a preference, then. |
|
Sounds good, but how do I depend on alternatives? |
|
Just a |
7906b52 to
8fa1f10
Compare
| ["sh" {os = "win32" & os-distribution != "cygwinports"} "curl-config" "--libs"] | ||
| ] | ||
| depexts: [ | ||
| ["libcurl4-gnutls-dev"] {os-family = "debian"} |
There was a problem hiding this comment.
just one last request is to rename conf-libcurl.2 to a new conf-libcurl.3 (with the current content), so that existing locked packages wont be affected.
8fa1f10 to
cbab600
Compare
|
This is causing a lot of temp failures, i've restarted: |
5086729 to
af2e0b5
Compare
Add two conf- packages depending on the OpenSSL and GnuTLS variants of libcurl. This lets the opam resolver use whatever is available. # Conflicts: # packages/conf-libcurl/conf-libcurl.3/opam
|
Those network failures were caused by attempts to fetch deb packages in a sandbox without network. The problem was that opam tried to switch between the openssl and gnutls variants without realizing that the underlying debian packages conflict. Noting this conflict in the opam conf- packages fixes most of the failures. The only remaining additional CI failure in comparison to the state of the repository before this PR (af2e0b5) is a failure in testing However that may be — all those failures are caused by attempts to download sources in a sandbox and not by a problem with this PR. Therefore to me it seems this is ready to commit now. |
da0b721 to
e95ea08
Compare
libcurl4-openssl-dev works as well as the gnutls variant. Therefore depend only on the libcurl-dev virtual package, which makes sure that any variant of libcurl4-*-dev is installed.