Skip to content

Remove Yojson.Raw - #206

Open
Leonidas-from-XIV wants to merge 6 commits into
ocaml-community:masterfrom
Leonidas-from-XIV:remove-raw
Open

Remove Yojson.Raw#206
Leonidas-from-XIV wants to merge 6 commits into
ocaml-community:masterfrom
Leonidas-from-XIV:remove-raw

Conversation

@Leonidas-from-XIV

Copy link
Copy Markdown
Member

The code is quite a mess of conditionals where different variants are enabled and disabled through CPPO variables. This makes understanding the code hard and confusing due to the code-generation obscuring what is happening in the code.

This PR removes one of the rarely-used variants, Yojson.Raw, which conveniently leaves only the variants which differ in Intlit (to be unified in a future PR).

Comment thread CHANGES.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant