Added munchernetworks to the server list+icon#22
Conversation
Yes, this is the community logo, please don't ask.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds a new server entry "ram munchers network" to servers.json with a description, WSS and IRCS endpoints, and feature flags (obsidian: false, sasl: true, voice: false). The new object does not include an icon field. ChangesServer Configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Server list probeScope: 1 server(s) changed vs
|
|
I was really not sure what "Voice" and "Obsidian" meant when i looked at the server list. |
|
Thanks for your submission, we'll get to it very soon. All the details you've put are not wrong and you can leave them as-is, but see below. For context, "Obsidian" (renaming to obbyircd here soon to reflect name changes) just means whether the server you're using is the one from our stack, which is still in the alpha stages of development. This is in preparation for improving the Discovery page to show people what servers support which features. One of the special (optional) features the stack provides is voice channels, which is the other option "Voice". You technically don't need to add your icon as if you specified one on your IRCd, that's where it'd show up in clients and on our discovery page. It seems like the scanner didn't pick on your icon. Since I noticed you're using UnrealIRCd 6.2.5, you can add something like this to your unrealircd.conf: |
Hey val, burgeresque here. |
|
and yeah, about that icon |
its best to remove this, as i set{} a network-icon in unreal.
rammunchersnetwork is a server that started out as an alternative to discord
we are not the reason that ram prices are up so much :P
and yes, windows terminal is our favicon. Please don't ask.
Summary by CodeRabbit