Skip to content

Added munchernetworks to the server list+icon#22

Open
RandomTNT wants to merge 4 commits into
obbyworld:mainfrom
RandomTNT:muncher-patch-1
Open

Added munchernetworks to the server list+icon#22
RandomTNT wants to merge 4 commits into
obbyworld:mainfrom
RandomTNT:muncher-patch-1

Conversation

@RandomTNT

@RandomTNT RandomTNT commented Jun 12, 2026

Copy link
Copy Markdown

rammunchersnetwork is a server that started out as an alternative to discord
we are not the reason that ram prices are up so much :P
and yes, windows terminal is our favicon. Please don't ask.

Summary by CodeRabbit

  • New Features
    • Added "ram munchers network" server option with configured connection endpoints (WebSocket and IRC over SSL).
    • Server advertises SASL support; Obsidian and voice features are disabled.
    • No icon is included for this server.

Yes, this is the community logo, please don't ask.
@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 33e060d9-8ff5-41be-b386-7bfcb3924abe

📥 Commits

Reviewing files that changed from the base of the PR and between 0aaeb97 and 589269b.

📒 Files selected for processing (1)
  • servers.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • servers.json

📝 Walkthrough

Walkthrough

Adds a new server entry "ram munchers network" to servers.json with a description, WSS and IRCS endpoints, and feature flags (obsidian: false, sasl: true, voice: false). The new object does not include an icon field.

Changes

Server Configuration

Layer / File(s) Summary
New server entry
servers.json
Insert a new server object for "ram munchers network" into the servers array with description, wss and ircs endpoints, and boolean flags obsidian, sasl, and voice. No icon property is present.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

I'm a rabbit tapping keys, hooray,
I nibble bytes and hop all day,
A server sprouts, new fields to see,
"Ram munchers" joins the family—whee! 🐇✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title claims an icon was added, but the changeset shows no icon field in the final servers.json entry; subsequent commits removed it after initial inclusion. Update the title to reflect the actual change: 'Added munchernetworks to the server list' or similar, removing the '+icon' reference since the icon was removed in favor of server-provided network-icon.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Server list probe

Scope: 1 server(s) changed vs origin/main

Server wss ircs obsidian sasl voice icon
ram munchers network

@RandomTNT

Copy link
Copy Markdown
Author

I was really not sure what "Voice" and "Obsidian" meant when i looked at the server list.
Please correct if needed.

@ValwareIRC

ValwareIRC commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Thanks for your submission, we'll get to it very soon. All the details you've put are not wrong and you can leave them as-is, but see below.

For context, "Obsidian" (renaming to obbyircd here soon to reflect name changes) just means whether the server you're using is the one from our stack, which is still in the alpha stages of development. This is in preparation for improving the Discovery page to show people what servers support which features. One of the special (optional) features the stack provides is voice channels, which is the other option "Voice".

You technically don't need to add your icon as if you specified one on your IRCd, that's where it'd show up in clients and on our discovery page. It seems like the scanner didn't pick on your icon.

Since I noticed you're using UnrealIRCd 6.2.5, you can add something like this to your unrealircd.conf:
set { network-icon 'https://link.to/your-icon.ico'; }, give her a /rehash and this will show up as expected here and in other clients which also support network icons.

@RandomTNT

RandomTNT commented Jun 12, 2026

Copy link
Copy Markdown
Author

Thanks for your submission, we'll get to it very soon. All the details you've put are not wrong and you can leave them as-is, but see below.

For context, "Obsidian" (renaming to obbyircd here soon to reflect name changes) just means whether the server you're using is the one from our stack, which is still in the alpha stages of development. This is in preparation for improving the Discovery page to show people what servers support which features. One of the special (optional) features the stack provides is voice channels, which is the other option "Voice".

You technically don't need to add your icon as if you specified one on your IRCd, that's where it'd show up in clients and on our discovery page. It seems like the scanner didn't pick on your icon.

Since I noticed you're using UnrealIRCd 6.2.5, you can add something like this to your unrealircd.conf: set { network-icon 'https://link.to/your-icon.ico'; }, give her a /rehash and this will show up as expected here and in other clients which also support network icons.

Hey val, burgeresque here.
Thanks for the heads up, it is really cool that your stack has voicechats!
i thought it was related to +v mode.
About the network icon, i will set it right now
have a nice time of day and happy IRcing!

@RandomTNT

Copy link
Copy Markdown
Author

and yeah, about that icon
that was the first community suggestion i saw
so i guess im sticking with it until i get/make a proper icon :P

its best to remove this, as i set{} a network-icon in unreal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants