Updates description for frontend projects#2
Open
samuelpearce wants to merge 1 commit into
Open
Conversation
Updates 'Next' to frontend Adds core-api project Fixes link to fileserver project
viktor-yakubiv
approved these changes
Aug 16, 2019
viktor-yakubiv
left a comment
viktor-yakubiv
left a comment
Contributor
There was a problem hiding this comment.
I do not mind. To be honest, I do not really care.
What makes me feel uncomfortable that we reference all our repositories from the (1) style guide, (2) public repository.
- The style guide is not appropriate place to explain what we do but the place, where we explain how we do. However, it's also the entrance to CORE for new people, so it also makes some sense.
- I link all our private repositories from the public place. It's just not polite. People can read the list but cannot open items. It makes the style guide partially useless.
viktor-yakubiv
added
the
documentation
Contributor
Author
|
@viktor-yakubiv you make a good point. An overview of projects is out of scope of a 'style guide'. I'd suggest we don't merge this PR but remove the section as a whole. @mcancellieri what do you think? |
Contributor
|
Are we going to merge this @samuelpearce? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I felt that frontend is clearer than 'next' and that the existing frontend is clearer as legacy, to show we are moving the projects contained within the project to other places
Updates 'Next' to frontend
Adds core-api project
Fixes link to fileserver project