[TW-5801] feat(dashboard): add SAML Enterprise SSO login via --provider saml#117
Merged
Conversation
…er saml - Add saml_SSO login type and map 'saml' provider in sso login - Add --email flag for home-realm discovery; prompt interactively when omitted - Thread email through SSOStart (ports, adapter, app service, mock) - Reject 'sso register --provider saml' with guidance (accounts are JIT-provisioned on first SAML login) - Server flow: dashboard-account mints a device-style flow; browser confirms the one-time code and completes SP-initiated SAML; poll returns DPoP-bound tokens Server-side counterpart: nylas/dashboard-v3#2026 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3df93f1170
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…the placeholder InputPrompt returns the placeholder in non-TTY runs and on empty submit, so 'you@company.com' became the HRD email. Use an empty placeholder so those paths fall through to the required-email error. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds SAML Enterprise SSO to CLI dashboard auth.
nylas dashboard sso login --provider saml --email you@company.comstarts a device-style flow against dashboard-account: the server does home-realm discovery from the email domain, the browser confirms the one-time code and completes the SP-initiated SAML login, and the CLI's poll returns DPoP-bound tokens. The existing poll loop, MFA handling, and org sync are unchanged.Changes
saml_SSOlogin type constant;samlaccepted by--provider(login only)--emailflag for home-realm discovery; interactive prompt when omittedSSOStartgains anemailparam (ports, adapter, app service, mock); sent only when non-emptysso register --provider samlreturns guidance instead — SAML accounts are JIT-provisioned on first loginTesting
go test ./...passes; new adapter test asserts the SAML start request carriesemailand omitsprivacyPolicyAcceptedgofmt/go vetcleanRelated
🤖 Generated with Claude Code