The update card loses its accent stripe - #297
Open
nyblnet wants to merge 1 commit into
Open
Conversation
The "Version X is available" card carried a 3px peach rule down its leading edge — the generic coloured-callout tic, and the only accent stripe anywhere in the app. The two other thick borders in styles.css are a CSS triangle (a disclosure arrow) and a quiet 2px neutral rule on .ed-lang-warn, so this was not part of the design language; it was bolted on. It was redundant as well as out of place. The card already announces itself: a heading that names the version, and a primary button that carries the accent. The stripe added a third emphasis to a card nobody could miss. It was also a hard-coded #FF9E8A, so it ignored the theme tokens and stayed peach in dark mode. The border is now an even 1px var(--line) like every other surface in the dialog, and themes with them: measured rgb(227,232,239) light, rgb(51,58,69) dark, uniform on all four sides.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Version X is available" card in the About dialog carried a 3px peach rule down its leading edge (
styles.css:718,border-inline-start: 3px solid #FF9E8A).It reads as the generic coloured-callout tic, and it is the only accent stripe anywhere in the app — the only other thick borders in the stylesheet are a CSS triangle (a disclosure arrow) and a quiet 2px neutral rule on
.ed-lang-warn. So it was not part of the design language.It was redundant as well as out of place: the card already announces itself with a heading naming the version and a primary button carrying the accent. The stripe was a third emphasis on a card nobody could miss.
And being a hard-coded hex, it ignored the theme tokens — it stayed peach in dark mode while everything around it moved.
After
An even 1px
var(--line)like every other surface in the dialog, and it themes with them:rgb(227, 232, 239)rgb(51, 58, 69)Verified by rendering the real card markup inside the About dialog in a built shell and reading computed styles in both themes. The peach now appears only on the "Update this file…" button.
For the next release — 1.0.17 is already out.