fix(editor): restore mobile Save button outline and fix dark toast text contrast - #295
Open
bouzidanas wants to merge 5 commits into
Open
fix(editor): restore mobile Save button outline and fix dark toast text contrast#295bouzidanas wants to merge 5 commits into
bouzidanas wants to merge 5 commits into
Conversation
…dark-mode' into fix-version-toast-appearance-in-dark-mode # Conflicts: # slides/src/styles.css
Contributor
Author
|
There is a similar issue (as the toast text color) with the button in the toast/info dialog that appears at the top when editor is opened in Safari browser in dark mode. Edit: latest commit fixes this now. |
…d given that their backgrounds do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
This PR fixes four small editor UI issues:
Mobile Save button outline
Below 700px, the save-as dropdown caret element is hidden, but Save retained the styling making it still look like the left half of a split button. This PR restores the missing right border and corner radii so Save renders as a complete button.
Toast text contrast
In dark mode, toast backgrounds switch through the theme while their fixed white text did not. Toast text now uses
var(--surface)so it remains readable in both themes.Primary button text contrast
.ed-btn-primaryusesvar(--ink)as its background. Since--inkchanges from dark in light mode to light in dark mode, a fixed white text color becomes unreadable in dark mode. Its text now usesvar(--surface).Active set-chip text contrast
.ed-setchip.activehas the same inverted theme treatment and the same fixed-white-text issue. Its text now also usesvar(--surface).UI comparisons
Mobile Save button
Toast
Primary Share action
Active hover-set chip
Verification
npm run build:singlepassedChecklist
npm run build:singlesucceeds fromslides/