Fixes and documentation updates needed while using this tool - #34
Open
npahucki wants to merge 2 commits into
Open
Fixes and documentation updates needed while using this tool#34npahucki wants to merge 2 commits into
npahucki wants to merge 2 commits into
Conversation
npahucki
commented
Apr 21, 2025
|
|
||
| error(message) { | ||
| console.error(chalk.red(`❌ ${message}`)); | ||
| error(message, error) { |
Author
There was a problem hiding this comment.
error parameter is being passed in calls, but was not used here, so the reason for the error was lost.
npahucki
commented
Apr 21, 2025
| file = new Blob([file], { type: file.type }); | ||
| } | ||
| // console.log(chalk.yellow("Created Blob from file object")); | ||
| } catch (e) { |
npahucki
commented
Apr 21, 2025
| ); | ||
| } catch (error) { | ||
| detailedLogger.error("Error uploading file:", error.message); | ||
| process.exit(0); |
Author
There was a problem hiding this comment.
This exited (with the incorrect code at that) when a file was too big to upload to a free workspace - this stopped the import which is not desired.
npahucki
commented
Apr 21, 2025
| const [fullMatch, userName, dateString] = body.match(/ \((.+) - (.+, [0-9]{4})\)$/) || []; | ||
| const createdAt = dateString ? new Date(dateString).toISOString() : undefined; | ||
| const createAsUser = userMapping[userName]?.linearName || userName; | ||
| if (createdAt && createAsUser) body = `${createAsUser} wrote:\n\n${body.slice(0, body.indexOf(fullMatch))}`; |
Author
There was a problem hiding this comment.
Since we can't (easily) specify the user who made the comment, putting the mapped user who wrote the comment at the top makes it clear who made the comment vs how Pivotal has it at the bottom using the Pivotal user name which may not be the same as the Linear use name.
…t get imported either (along with rejected)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into several issues while importing using the tool as it was: