Add WithSyncInterval option for delayed BBolt disk flushes - #4
Draft
reinkrul wants to merge 1 commit into
Draft
Conversation
…terval Instead of syncing after every transaction commit, the store batches pending writes and flushes them at most once per interval via a background goroutine. Close() always flushes any remaining dirty writes before shutting down. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
reinkrul
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WithSyncInterval(interval)option: instead of fsyncing after every transaction commit, a background goroutine batches pending writes and flushes at most once per intervalClose()always flushes any dirty writes before shutting down, so no data is silently lost on clean shutdownWithNoSync()behaviour is unchanged (backwards compatible)Config.SyncIntervalandConfig.DelayedSync()helper added for backend implementorsTest plan
TestBBolt_SyncInterval/data_is_flushed_on_close_when_dirty— writes survive a clean closeTestBBolt_SyncInterval/data_is_flushed_periodically— background goroutine fires within intervalBenchmarkBBolt_Flush— compare throughput of per-commit sync vs. interval syncgo test ./...)🤖 Generated with Claude Code