Layout issues fixed, newLogAlign called onresize - #1
Open
1wheel wants to merge 4 commits into
Open
Conversation
yed
pushed a commit
to yed/Goko-Salvager
that referenced
this pull request
Aug 6, 2013
Trying to catch up to Goko-Salvager...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was having the same overlap as issue as Kirian was having:
so I increased the spacing a little bit.
I also set a min width for the logs and stopped the body element from hiding overflow.
Finally, I couldn't figure out goko's onresize function enough to overwrite it like you did with the addLog function, so I used onresize and a Timeout to call newLogAlign after the canvas gets centered.
Thanks a bunch for making this!