feat: add not-starts/ends-with operators - #227
Merged
Merged
Conversation
3 tasks
Contributor
|
Would you please add new tests to this file? |
Contributor
Author
|
Added. Please let me know if I did something wrong, I have no idea about tree-sitter. |
fdncred
pushed a commit
to nushell/nushell
that referenced
this pull request
Oct 12, 2025
<!-- Thank you for improving Nushell! Please, read our contributing guide: https://github.com/nushell/nushell/blob/main/CONTRIBUTING.md --> Since no one seems opposed to it https://discord.com/channels/601130461678272522/615329862395101194/1426617232074608650 ## Release notes summary - What our users need to know <!-- This section will be included as part of our release notes. See the contributing guide for more details. Please include only details relevant for users here. Motivation and technical details can be added above or below this section. You may leave this section blank until your PR is finalized. Ask a core team member if you need help filling this section. --> Added `not-starts-with` and `not-ends-with` operators to be on par with other comparison operators, ## Tasks after submitting <!-- Remove any tasks which aren't relevant for your PR, or add your own --> - [x] Add tests - [x] Update the [documentation](https://github.com/nushell/nushell.github.io). nushell/nushell.github.io#2054 - [x] Update the tree-sitter grammar. nushell/tree-sitter-nu#227
Contributor
Looks good, but we also track the generated c/json code in this repo.
|
Contributor
Author
|
I have also committed the generated tree-sitter and all tests pass |
blindFS
approved these changes
Oct 12, 2025
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New operators added in nushell/nushell#16852