[W5.6][T16-2] Perry Wang Zhiming#191
Open
perrythewang wants to merge 9 commits into
Open
Conversation
…ble access from public to private, and added a getFeedbackToUser() method.
…ommandResult replaced with call to public getFeedbackToUser() method instead.
stephlewyh
reviewed
Sep 20, 2018
stephlewyh
left a comment
stephlewyh
left a comment
There was a problem hiding this comment.
Good try! You may also explore:
(1) declaring Contact class as an abstract class
(2) pushing subclass constructor code to superclass.
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { |
There was a problem hiding this comment.
if equals() is overriden, hashCode() also has to be overridden. you may find out why.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please refer to last commit on Sep 17 for W5.6a requirement