samuelory iP by samuelory · Pull Request #173 · nus-cs2113-AY2324S2/ip

samuelory · 2024-02-06T12:30:58Z

No description provided.

OKW32

Overall good job on following coding standards

OKW32 · 2024-02-08T03:38:30Z

+        int taskNo;
+        while (true) {
+            String input = scanner.nextLine();
+            switch (input.split(" ")[0]) {


Consider storing the first word of user input in a variable

Suggested change

switch (input.split(" ")[0]) {

String command = input.split(" ")[0]

switch (command) {

OKW32 · 2024-02-08T03:46:43Z

+
+
+        Task[] tasks = new Task[100];
+        int numItem = 0;


numberOfTasks might have been a better variable name

OKW32 · 2024-02-08T03:48:04Z

@@ -0,0 +1,38 @@
+public class Task {


I like that the boolean names sound booleany

OKW32 · 2024-02-08T03:48:57Z

@@ -0,0 +1,60 @@
+import java.util.Scanner;


I like that all variable names are declared with camelCase

Leong-ZM · 2024-02-08T06:01:13Z

+
+
+        Task[] tasks = new Task[100];
+        int numItem = 0;


unclear variable name

Leong-ZM · 2024-02-08T06:18:48Z

+        if (this.isDone){
+            return("[X] " + this.taskName);
+        }
+        else{


should be in one line: } else {

Leong-ZM · 2024-02-08T06:20:14Z

+        int taskNo;
+        while (true) {
+            String input = scanner.nextLine();
+            switch (input.split(" ")[0]) {


magic number: [0]?

Leong-ZM · 2024-02-08T06:20:59Z

+                    System.out.println("Alright, adding this task to the list: ");
+                    System.out.println(tasks[numItem]);
+                    numItem++;
+                    System.out.printf("You have %d tasks in the list.%n", numItem);


can use println instead

Leong-ZM · 2024-02-08T06:22:19Z

@@ -0,0 +1,38 @@
+public class Task {
+    protected String taskName;


unclear variable name: does taskName refer to the description, the type of the task, or the task object itself?

Geinzit

Overall very clean code and very rich features! Good Job!

Geinzit · 2024-02-08T06:30:05Z

@@ -0,0 +1,20 @@
+public class Event extends Task {


A better name to reflect the inheritance might be EventTask

Geinzit · 2024-02-08T06:30:51Z

@@ -0,0 +1,17 @@
+public class Deadline extends Task{


A better name to reflect the inheritance relationship might be DeadlineTask

Geinzit · 2024-02-08T06:32:52Z

+                    System.out.println("Alright, adding this task to the list: ");
+                    System.out.println(tasks[numItem]);
+                    numItem++;
+                    System.out.printf("You have %d tasks in the list.%n", numItem);


It's best to not repeat yourself, and put these commands into a separate method.

Geinzit · 2024-02-08T06:35:01Z

+        return taskName;
+    }
+
+    public boolean getDone(){


checkIsDone may be a better name to reflect the boolean nature of the variable to get

Joellimjr

Great job so far, but there are still a few improvements to be made

Joellimjr · 2024-02-08T08:07:35Z

+        super(description);
+        this.deadlineString = deadline;
+    }
+    @Override


Perhaps you can leave a line between methods for improved readability

Joellimjr · 2024-02-08T08:08:51Z

+        Task[] tasks = new Task[100];
+        int numItem = 0;
+        Scanner scanner = new Scanner(System.in);
+        int taskNo;


perhaps you can name it taskNum to make it more clear

Joellimjr · 2024-02-08T08:11:08Z

+                case ("unmark"):
+                    taskNo = Integer.parseInt(input.split(" ")[1])-1;
+
+                    if (input.split(" ")[0].equals("mark")){


perhaps set your mark case as its own case rather than a fallthrough and processing it within your unmark case. helps with readability as well

Joellimjr · 2024-02-08T08:12:25Z

+
+
+        Task[] tasks = new Task[100];
+        int numItem = 0;


Could be interpreted as item number or number of items which could be confusing

This reverts commit 171ab49.

aditichadha1310 · 2024-02-18T05:15:52Z

@@ -0,0 +1,17 @@
+public class Deadline extends Task{


Comments are missing for the entire code. Good to have them for better readability.

aditichadha1310 · 2024-02-18T05:16:14Z

+    private final String startTime;
+    private final String endTime;


Good work with the usage of Access Modifiers.

aditichadha1310 · 2024-02-18T05:16:56Z

+                return (false);
+            case ("list"):
+                System.out.println("Here are your tasks for today: ");
+                for (int i = 0; i < numItem; i++) {


Avoid usage of Magic Numbers and literals.

aditichadha1310 · 2024-02-18T05:17:40Z

+        printBreakLine();
+    }
+
+    private static boolean handleInput (String input) throws OGFException{


Very long method. Avoid long methods and take corrective action if a method exceeds 30 lines of code.

aditichadha1310 · 2024-02-18T05:20:06Z

+                printBreakLine();
+                break;
+            case ("todo"):
+                if (!input.contains(" ") || input.indexOf(" ") == input.length()-1){


This is a complex statement, so try to break it down into two boolean variables which handle each sub-expression.

Added Find

samuelory added 7 commits January 25, 2024 17:25

increment level-0

9a9bccc

increment level-1. Echo

1852599

increment level-3. Mark as Done

9af81ec

increment level-2. Add, List

2c66006

increment level-3. Mark as Done

5f84acc

increment level-3. Mark as Done

f7b20e1

increment A-CodingStandard

af5e58e

OKW32 reviewed Feb 8, 2024

View reviewed changes

Increment-4 ToDos, Events, Deadlines

a7f6b43

This comment was marked as outdated.

Sign in to view

Leong-ZM reviewed Feb 8, 2024

View reviewed changes

Geinzit reviewed Feb 8, 2024

View reviewed changes

samuelory added 2 commits February 8, 2024 15:26

A-TextUITesting: Automated Text UI testing

3efe9b4

A-codeQuality

8ef254c

Joellimjr reviewed Feb 8, 2024

View reviewed changes

samuelory added 6 commits February 14, 2024 23:31

Reduced nesting

8e0a49f

added exceptions for mark/unmark

cd122ec

added too many items in list exceptions

6662e54

added missing deadlines and event markers exceptions

b4bd9c1

commit

171ab49

Revert "commit"

a9cd40f

This reverts commit 171ab49.

aditichadha1310 reviewed Feb 18, 2024

View reviewed changes

samuelory added 8 commits February 22, 2024 15:40

Added delete function

972162b

Added hardware saving function

3521ffc

Merge branch 'branch-Level-6'

b886d19

Merged delete and save

2b73977

implemented jar file

9e42c44

Added more OOP

a4b7b0c

Added Find

604abdf

Merge pull request #1 from samuelory/branch-Level-8

c707014

Added Find

samuelory added 5 commits March 3, 2024 16:58

Added JavaDoc

f1c80aa

Updated README.md and code quality

09dfb25

Changed class names on README.md

6fc88b5

Changed the actual readme in the doc folder

78b45b8

Added chatbot name to top of user guide

00eb528

	switch (input.split(" ")[0]) {
	String command = input.split(" ")[0]
	switch (command) {

		@@ -0,0 +1,38 @@
		public class Task {
		protected String taskName;

		private final String startTime;
		private final String endTime;

Uh oh!

Conversation

samuelory commented Feb 6, 2024

Uh oh!

OKW32 left a comment

Choose a reason for hiding this comment

Uh oh!

OKW32 Feb 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OKW32 Feb 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OKW32 Feb 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Geinzit left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Joellimjr left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

OKW32 Feb 8, 2024 •

edited

Loading

OKW32 Feb 8, 2024 •

edited

Loading

OKW32 Feb 8, 2024 •

edited

Loading