[Lim Yuh Ching] iP#79
Conversation
ToDos, Events, Deadlines are created as a subclass of Task. Moved addToTask and printTask from Task class to Main program.
TeoHaoZhi
left a comment
TeoHaoZhi
left a comment
There was a problem hiding this comment.
Overall code is easy to read, little to no standard coding violations. Everything looks good to me
| @@ -0,0 +1,18 @@ | |||
| public class Deadlines extends Task { | |||
| String by; | |||
There was a problem hiding this comment.
Good following of spacing requirements
| private static int taskCount = 0; | ||
|
|
||
| public static void addToTasks(String description, Type type) { | ||
| switch (type) { |
There was a problem hiding this comment.
Good and clear use of switch statements
| System.out.println("\tNow you have " + taskCount + " task(s) in the list."); | ||
| } | ||
| public static void printTasks() { | ||
| if (taskCount == 0) { |
There was a problem hiding this comment.
Good use of if-statements, no nesting errors
TeoHaoZhi
left a comment
TeoHaoZhi
left a comment
There was a problem hiding this comment.
Missed out 1 comment previously, everything looks good to me
| super(description); | ||
| this.by = by; | ||
| } | ||
| public String getBy() { |
There was a problem hiding this comment.
Good following of naming of method conventions
DextheChik3n
left a comment
DextheChik3n
left a comment
There was a problem hiding this comment.
I really like how you structure your code! I just made some suggestions to the variable name to make your code more clear to understand
| Scanner scanner = new Scanner(System.in); | ||
| String userInput = scanner.nextLine(); | ||
| String[] substr = userInput.split("\\s+"); | ||
| switch (substr[0]) { |
There was a problem hiding this comment.
command handling is well-organised using a switch case which makes it easier to troubleshoot.
| } | ||
| } | ||
| } | ||
| public static void bye() { |
There was a problem hiding this comment.
Perhaps you could use a more clear method name such as printByeMessage?
| public static void bye() { | |
| public static void printByeMessage() { |
| tasks[taskCount] = new ToDos(description); | ||
| break; | ||
| case DEADLINE: | ||
| int i = description.indexOf("/"); |
There was a problem hiding this comment.
Maybe you can use a better variable name for the index like indexAfterBy? so that it is more clearer when you revisit the code
| case "bye": | ||
| bye(); | ||
| break; | ||
| case "list": | ||
| printTasks(); | ||
| break; | ||
| case "mark": | ||
| markAsDone(Integer.parseInt(substr[1])); | ||
| break; | ||
| case "unmark": | ||
| markAsUndone(Integer.parseInt(substr[1])); | ||
| break; | ||
| case "todo": | ||
| addToTasks(userInput.substring(5), Type.TODO); | ||
| break; | ||
| case "deadline": | ||
| addToTasks(userInput.substring(9), Type.DEADLINE); | ||
| break; | ||
| case "event": | ||
| addToTasks(userInput.substring(6), Type.EVENT); | ||
| break; | ||
| } |
There was a problem hiding this comment.
I like how you use switch statements for the various instructions. This makes your code very neat.
| this.description = description; | ||
| } | ||
|
|
||
| public boolean isDone() { |
There was a problem hiding this comment.
Perhaps the method could sound more verb-like?
| public boolean isDone() { | |
| public boolean checkIsDone() { |
| public enum Type { | ||
| TODO, DEADLINE, EVENT | ||
| } |
There was a problem hiding this comment.
Good use of enum for the various tasks!
irving11119
left a comment
irving11119
left a comment
There was a problem hiding this comment.
Overall, your code follows the standards decently. However, do look out for things like naming conventions and magic types which can be avoided and will help to improve your code.
| + "|____/ \\__,_|_|\\_\\___|\n"; | ||
| System.out.println("Hello from\n" + logo); | ||
| // Greetings | ||
| String intro = "~~~~~~~~~~~~~~~~~~~\n" |
There was a problem hiding this comment.
Perhaps this could be made a constant.
| int j = description.indexOf("/"); | ||
| int k = description.indexOf("/", j+1); |
There was a problem hiding this comment.
For the following methods, you could use more descriptive variables rather than single letter variables. This would be more in line with the naming conventions required.
The name change suggested by your classmate would be a good example of how to name the variable instead!
This reverts commit 2e8d61b.
# Conflicts: # src/main/java/Duke.java
Create TaskList, Parser, Ui and Storage to split the code in Duke into different objects
Add Javadoc to most of the class
5 participants
No description provided.