[Jiayan Ben] iP by J-Y-Yan · Pull Request #76 · nus-cs2113-AY2324S1/ip

J-Y-Yan · 2023-09-05T17:42:48Z

No description provided.

…1 - 4

…lised

…yet mateched

StanleyW00

Looks nice.
Just need to fix some of the names.

StanleyW00 · 2023-09-08T03:34:20Z

+        Task[] list = new Task[100];
+        int count = 0;


Perhaps the variable names should be renamed specifically to task in order to avoid confusion in the future.

Suggested change

Task[] list = new Task[100];

int count = 0;

Task[] tasks = new Task[100];

int tasksCount = 0;

StanleyW00 · 2023-09-08T03:40:10Z

+    public void Done(){
+        this.isDone = true;
+    }
+
+    public void unDone(){
+        this.isDone = false;
+    }


Perhaps these methods should be renamed to represent verbs.

Suggested change

public void Done(){

this.isDone = true;

}

public void unDone(){

this.isDone = false;

}

public void markAsDone(){

this.isDone = true;

}

public void unmarkAsDone(){

this.isDone = false;

}

StanleyW00 · 2023-09-08T03:41:24Z

+                if( (task > count ) || (task <1) ){
+                    System.out.println("Oops! You don't have the task in this positions.");
+                }


I like that you checked whether the task position is there or not.

StanleyW00 · 2023-09-08T03:46:02Z

+                break;
+
+            case "todo":
+                // command e.g. todo borrow book


I like that you put the example inputs for each type of tasks.

Cheezeblokz · 2023-09-08T04:10:13Z

@@ -0,0 +1,14 @@
+public class Deadline extends Task {
+
+    protected String by;


Confusing variable name, use noun for variables.

Suggested change

protected String by;

protected String userName;

Thanks for your suggestions. I have improved the naming for a few variables to avoid confusion.

Cheezeblokz · 2023-09-08T04:13:04Z

+            String command = scanner.nextLine();
+            String[] parts = command.split(" ");


Unspecific variable naming.

Suggested change

String command = scanner.nextLine();

String[] parts = command.split(" ");

String userCommand = scanner.nextLine();

String[] userInputParts = userCommand.split(" ");

Cheezeblokz · 2023-09-08T04:16:00Z

+    public String toString() {
+        return "[T]" + super.toString() ;
+    }
+}


Good use of inheritance in implementation of toString().

Cheezeblokz · 2023-09-08T04:21:35Z

+                break;
+
+            case "mark":
+                int taskNo = Integer.parseInt(parts[1]);   //assume  saved in part[1], need further improve


Comment could be more specific, and dumb downed for the reader instead of for own purpose.

… OO style

…simple output run

bentohset · 2023-09-14T03:56:08Z

+
+            case "deadline":
+                // command e.g. deadline return book /by Sunday
+                String[] ddlSplit = command.split("/");


Avoid using short forms as variable names as it might confuse readers with different backgrounds.

bentohset · 2023-09-14T03:56:30Z

+
+        while (true) {
+            String command = keyboard.nextLine();
+            String[] commendSplits = command.split(" ");


Small typo on "commendSplits"

bentohset · 2023-09-14T03:58:37Z

+        if( (taskNo > taskCount ) || (taskNo <1) ){
+            System.out.println("Oops! You don't have any task in this positions.");
+        }else if(this.isDone){
+            System.out.println("You have already completed the task.");
+        } else{


Spacing of the if else statements does not follow standards. Similar in other areas

…adability of the main(Duke) class - ready to trackle exception

- Seperate files into different package for easier management

-add file and data checker methods if files or folder not exist, create one; if failed to create, throw error for incorrect path -add backup method to save all currect data in current run of program -correct bugs on fileIO over creating new task or delete task

…e to collect task data

…ng when the file is not empty

… time

A-JavaDoc

J-Y-Yan added 2 commits September 6, 2023 01:31

add file "Hello.txt"

aa5ed3d

add new file "HelloAgain.txt"

28f7f8f

J-Y-Yan changed the title ~~Add a empty file "Hello.txt"~~ [Jiayan Ben] IP Sep 5, 2023

J-Y-Yan changed the title ~~[Jiayan Ben] IP~~ [Jiayan Ben] iP Sep 5, 2023

J-Y-Yan added 9 commits September 7, 2023 01:47

remove the file "Hello.txt" and "HelloAgain.txt"

1a006be

add new file "Deadline.java" as subclass of Tast

f963203

implement the main function Duke to finish the required tasks from lv…

ce21c8c

…1 - 4

add new file "Event.java" as subclass of Task

d6f4537

add new file "Task.java" as parent class of task objects

22f7501

add new file "Todo.java" as subclass of Task

a151504

add file "EXPECTED.txt" to test the output. ***content not yet initia…

752b8bf

…lised

add "input.txt" containing the input commands

abd1548

add "runtest.bat" to compile the file. ***main class location is not …

677d91b

…yet mateched

StanleyW00 reviewed Sep 8, 2023

View reviewed changes

Cheezeblokz reviewed Sep 8, 2023

View reviewed changes

J-Y-Yan added 3 commits September 10, 2023 13:28

rename a few variables and methods to aviod confusion

6617431

create more methods to different classes by code extraction to become…

0c932c0

… OO style

initialise the content of input and expected output txt to conduct a …

4024b7f

…simple output run

bentohset reviewed Sep 14, 2023

View reviewed changes

J-Y-Yan added 11 commits September 15, 2023 10:11

- add task object creation methods for all kind of task to improve re…

e01ca3e

…adability of the main(Duke) class - ready to trackle exception

remove unused variable spaceIndex

888d9c5

- Implement exception to catch some main error caused by user inputs

ec736b8

- Seperate files into different package for easier management

add the delete method and some exception handling for the method

f87152b

create directory 'data' and taskList.txt and corresponding backup fil…

73d4714

…e to collect task data

output jar file to release ver. 1.0 application

12e33ab

modify the clearData method so that it only clear data in the beginni…

e49be03

…ng when the file is not empty

fixed a bug of inputting consecutive space

0e0d08a

add command class to take care of command format issue

346d4bf

introduce command class and make large update to more OO implementation

5908426

J-Y-Yan and others added 30 commits October 21, 2023 19:02

Update README.md

076e890

Update README.md

e74a144

Update README.md

89afba9

Update README.md

6554b32

Update README.md

c9771ed

Update README.md

f98e169

Update README.md

05c9b9e

Update README.md

194de5e

Update README.md

a8bd915

Update README.md

88d20d2

Update README.md

d89c626

Update README.md

70f7f2b

Update README.md

6d96bf2

Update README.md

a1d77ec

Update README.md

2313371

Update README.md

52df463

Bugs fixed in using empty find command and mulfunctions of validating…

20bc921

… time

Update README.md

c25848c

Update README.md

7e8712d

Update README.md

564d7d8

Update README.md

aa8a38c

Update README.md

dc6e648

Add more documentations

303fd3d

Update README.md

dbb5b0b

Update README.md

2a2d9a1

Update README.md

9dd679e

Update README.md

8b13eb1

Update README.md

815481e

Update README.md

5996557

Merge pull request #3 from J-Y-Yan/A-JavaDoc2.0

f57a735

A-JavaDoc

		@@ -0,0 +1,14 @@
		public class Deadline extends Task {

		protected String by;

		String command = scanner.nextLine();
		String[] parts = command.split(" ");

Uh oh!

Conversation

J-Y-Yan commented Sep 5, 2023

Uh oh!

StanleyW00 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants