[Yeon Jeho] iP#71
Open
ICubE01 wants to merge 61 commits into
Open
Conversation
J0shuaLeong
reviewed
Sep 6, 2023
Jonoans
reviewed
Sep 6, 2023
Jonoans
left a comment
Jonoans
left a comment
There was a problem hiding this comment.
Your code is quite well organised, though I think there are some minor things you might have missed for coding standard violations!
Jonoans
reviewed
Sep 6, 2023
Add command classes Add exceptions Handle user input exceptions
Fix error in unmark command
exetr
reviewed
Sep 17, 2023
exetr
left a comment
exetr
left a comment
There was a problem hiding this comment.
Great work on your iP so far! I have left some comments for your consideration in improving the code quality. Do remember to keep an eye out for usage of magic literals.
SaveFile -> Storage CommandXXX -> XXXCommand
Reduce static parts from Nuke, Storage, Ui
Reduce magic literals
Add find command
NukeDataTime supports both String and LocalDateTime for time variants
Branch level 8
Branch level 9
Branch a javadoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.