[CS2113-T13-2] Expense Tracker by FanZixian · Pull Request #79 · nus-cs2113-AY2223S2/tp

FanZixian · 2023-03-13T13:33:18Z

Our app will help users easily open/close accounts, keep track of past transactions as well as transfer money from one account to another easily with built in currency converters. The system would also verify the validity of transaction requests before they are carried out.

ArtemiszenN · 2023-03-29T04:45:06Z

+exposed in the `Parser` class.

+Given below is an example usage of the feature.
+![](./diagrams/AddFeature.png)


Consider describing a little bit about what's going on in the functions called, like use refs or something.

darrenangwx · 2023-03-29T07:12:38Z

 {Describe the design and implementation of the product. Use UML diagrams and short code snippets where applicable.}
+## Design
+![](diagrams/Overall.png)
+Our main `Duke` class is responsible for the instantiation and launch of our application.  


There is a formatting issue at this line. I think a double space is missing on line 14 to make it a new paragraph

darrenangwx · 2023-03-29T07:16:02Z

 {Describe the design and implementation of the product. Use UML diagrams and short code snippets where applicable.}
+## Design
+![](diagrams/Overall.png)
+Our main `Duke` class is responsible for the instantiation and launch of our application.  


Hmm, I see that your product is called Expense Tracker but the Main Class for this product is called Duke. Perhaps it would be better to rename the Class to fit the product? So that I as a developer won't be confused as to why the class is named Duke.

Jjzeng123 · 2023-03-30T01:05:56Z


+* [JSON-java](https://github.com/stleary/JSON-java)
+* [three-ten-extra](https://www.threeten.org/threeten-extra/)
+* * Requesting and Parsing of data from API into Java


Appears to be a duplicated bullet point in this line, possible formatting error?

Jjzeng123 · 2023-03-30T01:06:52Z

+* [JSON-java](https://github.com/stleary/JSON-java)
+* [three-ten-extra](https://www.threeten.org/threeten-extra/)
+* * Requesting and Parsing of data from API into Java
+* https://www.youtube.com/watch?v=lDEfoSwyYFg


I believe it would be beneficial if this link was a hyperlink, making it easier for readers to click on it.

Jjzeng123 · 2023-03-30T01:10:01Z

+- `CommandTotal#getTotal()` -- Returns the total in 2 decimal places.
+
+
+Displayed below is a part of the class diagram for `CommandTotal`.


Possible formatting error here, the image is in the middle of a the line instead of being on a new line and the "displayed below" is actually next to the image rather than above. Possible need to insert a newline using the multiple spaces at the end of the line method as the next line also starts immediately after the image rather than on a new line

Jjzeng123 · 2023-03-30T01:13:39Z

-|--------|----------|---------------|------------------|
-|v1.0|new user|see usage instructions|refer to them when I forget how to use the application|
-|v2.0|user|find a to-do item by name|locate a to-do without having to go through the entire list|
+| Version | As a ...          | I want to ...                                               | So that I can ...                                                                        |


Jjzeng123 · 2023-03-30T01:20:56Z

+exposed in the `Parser` class.
+
+Given below is an example usage of the feature.
+![](./diagrams/AddFeature.png)


Perhaps it would be nice to standardize the fonts in the diagrams, as the words in some diagrams are bolded and the words in others are not bolded

thant · 2023-03-30T03:16:00Z

+* https://www.youtube.com/watch?v=lDEfoSwyYFg
 ## Design & implementation
-
 {Describe the design and implementation of the product. Use UML diagrams and short code snippets where applicable.}


Perhaps this should be replaced with something along the lines of "This section describes the design and implementation of the product, with UML diagrams and code snippets where applicable." instead.

thant · 2023-03-30T03:18:48Z

+
+Displayed below is a part of the class diagram for `CommandTotal`.
+![](diagrams/TotalFeature.png)
+Give below is an example usage of the feature.


Possible typo, should rephrase as "Given below is an example usage of this feature."

Rayleigh47

Overall good job!

Rayleigh47 · 2023-03-30T04:21:02Z

+Step 4. `CommandAdd#execute` instantiates a new `Expense` object with the returned `parsedInput[]` and adds it to
+`expenseList`.
+
+### "Delete" feature


Can consider standardizing the header for "Delete" feature whether to address it as ' ' or " " as the rest use singular quotation marks.

Rayleigh47 · 2023-03-30T04:27:54Z

+to extract `month` and `year` from user input. It then calls on `Monthly Overview` if both `month` and 'year' 
+are not null, which makes use of `MonthFilter` to filter out expenses in that specific month and returns sum by 
+category sorted in descending order before printing out the final overview in the intended format.
+


Formatting error with month and 'year', I think can consider describing / explaining how YearFilter works besides just MonthFilter as both methods are called.

For the diagram I think there's a small typo for filteredExpenses(), otherwise good job, it looks quite detailed and readable.

Rayleigh47 · 2023-03-30T04:34:11Z

+
+
+Displayed below is a part of the class diagram for `CommandTotal`.
+![](diagrams/TotalFeature.png)


I think can consider reformatting the text below the diagram and align it to make it neater.

Rayleigh47 · 2023-03-30T04:37:29Z

+
+Given below is an example usage scenario and how the 'delete' mechanism behaves at each step.
+
+![](./diagrams/DeleteFeature.png)


The diagram is missing the activation bar for Duke.

Rayleigh47 · 2023-03-30T04:38:20Z

+`expenseList.getExpenseList()` and `parser.extractIndex(input)`.
+
+Step 3. `CommandDelete#execute()` removes the expense at index specified by the user.
+


I think a step by step approach to explain how the command works is a good idea and gives a clear summary of what the method is about, good job.

exetr

Good job on the DG so far, continue to keep improving it. I have left some comments regarding certain issues. Primarily, do ensure that you provide sufficient elaboration both through text and diagrams such that they help to reduce ambiguity for audiences reading your DG.

exetr · 2023-04-01T16:47:48Z

+
+Given below is an example usage scenario and how the 'delete' mechanism behaves at each step.
+
+![](./diagrams/DeleteFeature.png)


Consider extending this sequence diagram to also show what you mentioned in step 3 - how an expense is deleted, in order to add value to this diagram.

exetr · 2023-04-01T16:49:49Z

+category sorted in descending order before printing out the final overview in the intended format.
+
+Given below is the sequence diagram to explain how the 'monthly overview' mechanism behaves.
+![](diagrams/MonthlyOverview.png)


While I am able to understand the role of yearFilter and monthFilter after reading, do consider adding further elaborations to ensure how both filters work.

exetr · 2023-04-01T16:50:40Z

+category sorted in descending order before printing out the final overview in the intended format.
+
+Given below is the sequence diagram to explain how the 'monthly overview' mechanism behaves.
+![](diagrams/MonthlyOverview.png)


The return line from monthFilter to MonthlyOverview is missing a closing bracket

…into brachAccount

Branch ped

Branch help

…test

…pt "" input by default to set the category to uncategorized

…e, which makes this method more User friendly.

Branch case sensitivity

Update UG and code comment

Update AboutUs

format DG

formatting

Add Comment

Update helper and Message file

fix noSuchElement upon terminating

check hasNextLine for scanner

ArtemiszenN reviewed Mar 29, 2023

View reviewed changes

darrenangwx reviewed Mar 29, 2023

View reviewed changes

Jjzeng123 reviewed Mar 30, 2023

View reviewed changes

thant reviewed Mar 30, 2023

View reviewed changes

Rayleigh47 reviewed Mar 30, 2023

View reviewed changes

exetr reviewed Apr 1, 2023

View reviewed changes

FanZixian and others added 24 commits April 3, 2023 12:13

Update import

bf019eb

Help message at the first time

8002220

Add the Helper method

8dff7a9

Update UG and some information

13b4e36

Merge branch 'master' of https://github.com/AY2223S2-CS2113-T13-02/tp

918a82f

Merge branch 'brachAccount' of https://github.com/arsdorintbp2003/tp …

399dae5

…into brachAccount

Update MessageList.java

72e6dc8

Merge pull request #156 from FanZixian/branch-PED

46c4548

Branch ped

Merge pull request #157 from FanZixian/branch-help

89b1883

Branch help

Update case sensitivity problem for find method, and also update the …

90ff69d

…test

Update case sensitivity problem for category method, also it can acce…

6f430b9

…pt "" input by default to set the category to uncategorized

Update category method if the input is not stored in the system befor…

9407bed

…e, which makes this method more User friendly.

Merge pull request #159 from FanZixian/branch-casesensitive

394b4f3

Branch case sensitivity

Update Sort method to be more user friendly

79fabd4

Update UG

9a2a727

Merge branch 'master' of https://github.com/AY2223S2-CS2113-T13-02/tp

6b46b64

Update UG and code comments to currency.java

241d168

Merge pull request #160 from GohJW/branch-ug-dg-ppp

f60e5bf

Update UG and code comment

Update AboutUs

aec9774

Merge pull request #161 from GohJW/branch-ug-dg-ppp

0b7c8ea

Update AboutUs

Code refactor

68a75ae

Merge branch 'branch-casesensitive' into branch-coderefactor

431a3dc

Bug fix

56a07ad

Merge branch 'master' of https://github.com/FanZixian/tp

7d140b6

GohJW and others added 30 commits April 10, 2023 18:22

Merge pull request #200 from GohJW/master

02b3ad0

format DG

update ToC

6331618

update ToC

ecbbcaa

Update DG formatting

e6ba57b

Merge branch 'master' of https://github.com/AY2223S2-CS2113-T13-02/tp

6b276c1

Merge pull request #201 from GohJW/master

0b7c0c4

formatting

update DG ToC

53b633b

Update DeveloperGuide.md

9ae5fe2

Update DeveloperGuide.md

acfb6bb

Update DeveloperGuide.md

e8438ad

Update ju-can.md

f10fee7

Update DeveloperGuide.md

483a9f8

Add Comment

962c566

Update DeveloperGuide.md

40cb849

Update DeveloperGuide.md

39b2b4e

Merge pull request #202 from arsdorintbp2003/master

3480bc0

Add Comment

Update helper and Message file

f35bf6c

Merge pull request #203 from Ju-Can/helper-page

c8f14f1

Update helper and Message file

fix noSuchElement upon terminating

b8bcd99

remove unused import

ac50f7a

Merge pull request #204 from Ju-Can/bug-fix

97b212f

fix noSuchElement upon terminating

check hasNextLine for scanner

1d375b9

Merge pull request #206 from Ju-Can/scanner-bugfix

d3b79ed

check hasNextLine for scanner

Update UserGuide.md

dae27f2

Update UserGuide.md

ff796b1

Update DeveloperGuide.md

07be2dc

Update DeveloperGuide.md

5a648af

Change PPP filename to the correct format

4494fe2

Change PPP filename to the correct format

3fbd41a

Change PPP filename to the correct format

0bdb9ba

		- `CommandTotal#getTotal()` -- Returns the total in 2 decimal places.


		Displayed below is a part of the class diagram for `CommandTotal`.



		Displayed below is a part of the class diagram for `CommandTotal`.
		![](diagrams/TotalFeature.png)


		Given below is an example usage scenario and how the 'delete' mechanism behaves at each step.

		![](./diagrams/DeleteFeature.png)

		`expenseList.getExpenseList()` and `parser.extractIndex(input)`.

		Step 3. `CommandDelete#execute()` removes the expense at index specified by the user.

Uh oh!

Conversation

FanZixian commented Mar 13, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Rayleigh47 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

exetr left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants