[CS2113-T12-2] Big-PP#23
Open
Magmanat wants to merge 615 commits into
Open
Conversation
kyrixn
added a commit
to kyrixn/tp
that referenced
this pull request
Mar 13, 2023
…Storage Merge Storage to master
Vignesh-30
reviewed
Mar 29, 2023
de-yi
reviewed
Mar 29, 2023
Manoj364
reviewed
Mar 29, 2023
Developer Guide Viewer Add Command sequence diagram
Compatibility check
SpawnageLoong
left a comment
SpawnageLoong
left a comment
There was a problem hiding this comment.
Overall good explanation, but class diagrams tend to be excessively detailed to the point that they cannot be read without zooming in.
kairuler
reviewed
Mar 30, 2023
kairuler
left a comment
kairuler
left a comment
There was a problem hiding this comment.
Overall really nice DG :) I liked how some of the classes use a Initialization, Functionality, Behavior structure
|  | ||
| ### PC Class Architecture | ||
|
|
||
|  |
There was a problem hiding this comment.
In the DG, the Component class is said to be an abstract class but in the diagram, it isn't shown as an abstract class. If I didn't misunderstand the diagram, perhaps this is a mistake?
notbingsu
reviewed
Mar 31, 2023
sistine-yu
reviewed
Mar 31, 2023
| ## Design & implementation | ||
|
|
||
| {list here sources of all reused/adapted ideas, code, documentation, and third-party libraries -- include links to the original source as well} | ||
| ### UI class |
There was a problem hiding this comment.
Maybe a multiplicity needs to be added between UI and UIState as well.
Bugs with filter command
…mmands Update ViewerHelpCommand to include filter commands Update return message in PCList
Minor changes to price handling
Fix bugs for exception message in listcommand
Fix userguide and Dg
Handle ParseFloat infinity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a command-line tool designed to help you pick computer parts based on your needs and budget.