Bui Phuong Nam ip#236
Open
arsdorintbp2003 wants to merge 53 commits into
Open
Conversation
Add, List
Add, List
Added Mark & Unmark
exetr
reviewed
Feb 18, 2023
exetr
left a comment
exetr
left a comment
There was a problem hiding this comment.
Good progress on your iP! I have left some comments regarding some areas for improvement.
| package Arsdorint.task; | ||
|
|
||
| public class Deadline extends Task { | ||
| public static final String typeDeadline = "D"; |
There was a problem hiding this comment.
Consider renaming your constant variables to all uppercase in order to maintain consistency and adhere to the module's coding standards.
| package Arsdorint.task; | ||
|
|
||
| public class Event extends Task { | ||
| public static final String typeEvent = "E"; |
There was a problem hiding this comment.
Similarly, consider renaming your constant variables to all uppercase
Comment on lines
+17
to
+56
| private static final int MAX_NUM_OF_TASKS = 100; | ||
| private static final String EXIT_MESSAGE = " Bye. Hope to see you again soon!\n"; | ||
| private static final String HELLO_MESSAGE = | ||
| " Hello! I'm Arsdorint, a member of Arsdorint Team.\n" + | ||
| " Please Type The Command As Follow:\n"; | ||
| private static final String COMMAND_LIST_MESSAGE = | ||
| "> Type \"list\" to list all the tasks. \n" + | ||
| "> Type \"mark\" follow by a number x to mark x tasks in the list. \n" + | ||
| "> Type \"unmark\" follow by a number y to unmark y tasks in the list. \n" + | ||
| "> Type \"todo\" follow by a string x to add a work that need to be done. \n" + | ||
| "> Type \"deadline /x y\" with x is the type of work, y is the time or date of the deadline. \n" + | ||
| "> Type \"event x /y\" with x is the event, y is the time or date of that event. \n" + | ||
| "> Type \"bye\" to exit. \n"; | ||
| private static final String QUESTION = " What can I do for you?"; | ||
|
|
||
| private static final String STORAGE_DIRECTORY = "./storage"; | ||
| private static final String STORAGE_FILE_NAME = "./storage/arsdorintTask.txt"; | ||
| private static final String MESSAGE_NEW_FILE = "File created"; | ||
| private static final String MESSAGE_OVERWRITE_FILE = "File overwritten"; | ||
| private static final String MESSAGE_LOAD_FILE = "File loaded"; | ||
| private static final String MESSAGE_NO_FILE = "There is no existing file"; | ||
| private static final String MESSAGE_WRONG_FILE = "The storage files entry is invalid. Please save to overwrite"; | ||
| private static final String MESSAGE_DIVIDER = | ||
| "____________________________________________________________"; | ||
| private static final String MESSAGE_DIVIDER_LIST = | ||
| "____________________________LIST____________________________"; | ||
| private static final String MESSAGE_DELETE = "Noted. I've removed this task:"; | ||
|
|
||
| private static final String ERROR_MESSAGE_BYE = " "; | ||
| private static final String ERROR_MESSAGE_LIST = " "; | ||
| private static final String ERROR_MESSAGE_MARK = | ||
| "=( OOPS!!! The description of a mark cannot be empty.\n" + "Syntax for mark\n\t" + | ||
| ">>> mark <item index number> \n" + "Note: item index must exist in the current list"; | ||
| private static final String ERROR_MESSAGE_UNMARK = | ||
| "=( OOPS!!! The description of an unmark cannot be empty.\n" + "Syntax for unmark\n\t" + | ||
| ">>> unmark <item index number> \n" + "Note: item index must exist in the current list"; | ||
| private static final String ERROR_MESSAGE_TODO = | ||
| "=( OOPS!!! The description of a todo cannot be empty.\n" + "Syntax for todo\n\t>>> todo <task>"; | ||
| private static final String ERROR_MESSAGE_DEADLINE = | ||
| "=( OOPS!!! The description of a deadline cannot be empty.\n" + |
There was a problem hiding this comment.
You can consider relocating all your messages to a separate java file in order to improve code readability of Arsdorint.java.
|
|
||
|
|
||
| public static void removeTaskMessage(int idx) { | ||
| //showToUser(MESSAGE_DIVIDER); |
There was a problem hiding this comment.
If you no longer plan to use this line of code, consider removing it.
Comment on lines
+306
to
+328
| if (lowerCaseLine.equals("bye")) exit(); | ||
| else if (lowerCaseLine.contains("list")) { | ||
| System.out.println("Here are the tasks in your list:\n"); | ||
| list(); | ||
| } | ||
| else if (lowerCaseLine.equalsIgnoreCase("mark")) { | ||
| mark(splitLine); | ||
| } | ||
| else if (lowerCaseLine.equalsIgnoreCase("unmark")) { | ||
| unmark(splitLine); | ||
| } | ||
| else if (lowerCaseLine.equalsIgnoreCase("todo") || | ||
| lowerCaseLine.equalsIgnoreCase("deadline") || | ||
| lowerCaseLine.equalsIgnoreCase("event")) add(command); | ||
| //add command when user don't type the instruction's TaskList.command | ||
| else if (lowerCaseLine.equalsIgnoreCase("delete")) { | ||
| delete(splitLine); | ||
| } | ||
| else if (lowerCaseLine.equalsIgnoreCase("save")) { | ||
| save(); | ||
| } | ||
| else wrongCommandMessage(); | ||
| } |
There was a problem hiding this comment.
Consider re-organising this if-else block to match the format stated in the coding standard, in order to maintain consistnecy.
A-Userguide
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.