[Caleb Chan] iP#191
Open
calebcjl wants to merge 26 commits into
Open
Conversation
ngyida
reviewed
Feb 2, 2023
ngyida
left a comment
ngyida
left a comment
There was a problem hiding this comment.
Mostly clean code that is easy to follow. Minor amendments to naming and cosmetics requested.
heejet
reviewed
Feb 2, 2023
heejet
left a comment
heejet
left a comment
There was a problem hiding this comment.
Overall good job following the java coding standards. Variables names are in camelCase, constant names are in uppercase with underscore to separate the words. Method names are verbs.
New classes are: 1. Deadline - Task with due date 2. Event - Task with start and end date 3. Todo - regular Task
Exceptions added: 1. DukeCommandExeception: user entered invalid command 2. DukeInputFormatException: user input has wrong format
siyuancheng178
left a comment
siyuancheng178
left a comment
There was a problem hiding this comment.
Great! Very concise and readable code. No coding violation found
Add feature to find and list tasks containing a keyword
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.