Refactor code and update tests#2
Open
okkhoy wants to merge 1 commit into
Open
Conversation
okkhoy
commented
Jan 27, 2023
|
|
||
| public class Contacts0 { | ||
|
|
||
| public static final int MAX_ENTRIES = 100; |
Contributor
Author
There was a problem hiding this comment.
good job extracting the constant
okkhoy
commented
Jan 27, 2023
| System.out.println("|| ==================================================="); | ||
| String[][] list = new String[100][3]; | ||
| showWelcomeMessage(); | ||
| String[][] list = new String[MAX_ENTRIES][3]; |
Comment on lines
+147
to
+154
| private static void showWelcomeMessage() { | ||
| System.out.println("|| ==================================================="); | ||
| System.out.println("|| ==================================================="); | ||
| System.out.println("|| Contacts - Version 0.1"); | ||
| System.out.println("|| Welcome to Contacts!"); | ||
| System.out.println("|| ==================================================="); | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Can extract some more constants
darrenangwx
reviewed
Jan 27, 2023
Comment on lines
+10
to
+11
| showWelcomeMessage(); | ||
| String[][] list = new String[MAX_ENTRIES][3]; |
Comment on lines
+149
to
+152
| System.out.println("|| ==================================================="); | ||
| System.out.println("|| Contacts - Version 0.1"); | ||
| System.out.println("|| Welcome to Contacts!"); | ||
| System.out.println("|| ==================================================="); |
woowenjun99
suggested changes
Jan 27, 2023
| } | ||
|
|
||
| private static void showWelcomeMessage() { | ||
| System.out.println("|| ==================================================="); |
There was a problem hiding this comment.
Create a function to print this to reduce the use of the repeated print?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract method
Update test