[Deen Liong] iP#83
Conversation
sevenseasofbri
left a comment
sevenseasofbri
left a comment
There was a problem hiding this comment.
Hi Deen, good job on the iP so far! I have added some comments on the code quality, coding standard violations and naming conventions. Hope they will be helpful. 👍🏽
| System.out.println("What can I do for you?"); | ||
| } | ||
|
|
||
| public static void main(String[] args) { |
There was a problem hiding this comment.
This function is very long (>30lines). Do consider breaking it down into multiple smaller functions.
|
|
||
| public class TaskManager { | ||
|
|
||
| public static void printSuccessfulAdd(Task[] tasks, int taskCount) { |
There was a problem hiding this comment.
Perhaps avoid the usage of magic literals and consider refactoring them to final variables instead.
|
|
||
| public static void printTaskList(Task[] tasks, int taskCount) { | ||
| System.out.println("\t_____________________"); | ||
| // if there are no task |
There was a problem hiding this comment.
This comment may be redundant. Consider removing it
| package duke.exception; | ||
|
|
||
| public abstract class DukeException extends Exception { | ||
| //no other code needed |
There was a problem hiding this comment.
You don't need to add comments where it is perhaps not necessary to do so.
| } | ||
|
|
||
| public String getStatusIcon() { | ||
| if (isDone) { // mark done task with X |
There was a problem hiding this comment.
Maybe remove the comment here since it is redundant and the code explains itself well already.
| public String toString() { | ||
|
|
||
| return getStatusIcon() + description; | ||
| // return getStatusIcon() ; |
There was a problem hiding this comment.
Avoid leaving commented out code in your codebase, since it reduces readability
small bug - bye now prints error message
1 - bye error message still show 2 - printing of number of items in inputFile at the start
Branch level 9
Branch level 9
Added User Guide
2 participants
No description provided.