[John Toh] iP by jjtoh · Pull Request #62 · nus-cs2113-AY2223S1/ip

jjtoh · 2022-08-29T18:02:08Z

No description provided.

Improved code formatting

Duke can now add tasks and mark/unmark them

Edited some code to align it with the given stardards

Coding quality may need further improvement.

Has issues running the tests

Testing still has issues

matthewphua · 2022-09-01T09:34:02Z

+
+    @Override
+    public String toString() {
+        return "[E]" + super.getStatusIcon()+ " " + super.getDescription() + " (at: " + at + ")";


consider adding space after getStatusIcon().

Franky4566

Well written code with good breakdowns. Just some minor issues and issue of SLAP.

Franky4566 · 2022-09-01T10:02:30Z

+    }
+
+    public static void handleTodo(String input) {
+        String[] splitInput = input.split(" ", 2);


Consider naming 2 as a constant, difficult to tell what the number 2 means

Franky4566 · 2022-09-01T10:06:47Z

+    private static final String MARK = "mark";
+    private static final String UNMARK = "unmark";
+
+    public static void handleInput() {


Consider adding comments for all ur functions so it is more readable, as described in the code quality page on the module website

Franky4566 · 2022-09-01T10:10:34Z

+            System.out.println("Marked this task: \n " + tasks[target - 1]);
+        } else {
+            System.out.println("Unmarked this task: \n" + tasks[target - 1]);
+        }
+        System.out.println(LINE_DIVIDER);


Phrases "Marked this task: \n" and "Unmarked this task: \n" can be written as a constant String when outputting
like line 21 declared in line 5

Franky4566 · 2022-09-01T10:27:24Z

+        String[] splitInput = input.split(" ", 2);
+        String[] splitCommand = splitInput[1].split(" /by ", 2); // 0 is description, 1 is by
+        Deadline deadline = new Deadline(splitCommand[0], splitCommand[1]);
+        TaskList.addDeadLine(deadline);


lines 32 and 33 can be abstracted into another function as the splitting is quite complicated (SLAP issue). Once extracted can be declared like line 35

Nothing of value is added

Can merge as level 6

Merge with level 7 branch in future

This reverts commit 3ea3669.

exetr

Great job on your code so far! Good to see a effective use of packaging within your application. The few comments I have left aims to improve the consistency in certain aspects of your code base.

exetr · 2022-09-17T17:44:41Z

+            UI.welcomeUser();
+            FileManager.startReading();
+            InputHandler.handleInput();


You should set the indentation to 4 spaces to ensure consistency and in adherance to the coding standard.

exetr · 2022-09-17T17:45:52Z

+
+public class FileManager {
+
+    private static Path taskDataPath = Paths.get(System.getProperty("user.dir"), "data", "tasks.txt");


Maybe consider replacing the tasks.txt portion with a constant, to eliminate magic literals.

exetr · 2022-09-17T17:46:40Z

+        File f = new File(filePath);
+        Scanner s = new Scanner(f);
+        while (s.hasNext()) {
+            String[] input = s.nextLine().split(" | ");


Similarly, consider setting the delimiter you use as a constant, in order to eliminate magic literals.

exetr · 2022-09-17T17:47:39Z

+    private static final String TODO = "todo";
+    private static final String LIST = "list";
+    private static final String DEADLINE = "deadline";
+    private static final String EVENT = "event";
+    private static final String BYE = "bye";
+    private static final String MARK = "mark";
+    private static final String UNMARK = "unmark";
+    private static final String DELETE = "delete";


Great usage of final variables!

exetr · 2022-09-17T17:48:04Z

+    private static final String DELETE = "delete";
+
+    public static void handleInput() {
+        boolean exit = false;


Consider renaming the boolean to isExit, in adherence to the naming convention.

exetr · 2022-09-17T17:49:21Z

+    private static String getCommand(String input) {
+        return input.split(" ", 2)[0].trim();
+    }
+
+    private static String getAction(String input) throws ArrayIndexOutOfBoundsException {
+        return input.split(" ", 2)[1].trim();
+    }


You could instead set the delimiter as a constant to eliminate magic literals.

exetr · 2022-09-17T17:50:49Z

+        System.out.println(LINE_DIVIDER);
+    }
+
+    private static void printMark(int target, boolean mark) {


Consider renaming the mark variable to isMarked, to keep consistency in naming convention.

Add Level 9

Repackaged some files

Add JavaDoc

jjtoh added 10 commits August 19, 2022 01:18

Add Increment: Level-0

aae34ba

Add Level-1

5701ddc

"Add Level-2"

ba4ed0c

Improved code formatting

Add Level-3

2ab974a

Duke can now add tasks and mark/unmark them

Add A-CodingStandard

8df32c3

Edited some code to align it with the given stardards

Add new java classes for level 4

e832747

Add some incomplete code for level 4

751198d

Add Level-4 with some improvements to code quality

ace71c1

Coding quality may need further improvement.

Add test cases

5b1fa36

Has issues running the tests

Change expected output

efd57f2

Testing still has issues

matthewphua reviewed Sep 1, 2022

View reviewed changes

Franky4566 reviewed Sep 1, 2022

View reviewed changes

jjtoh added 14 commits September 8, 2022 03:54

Add Level-5 and A-Exception

7b0ca7f

Add A-Packages

ae8e7eb

Add some temporary code

3ff482f

Nothing of value is added

Add ability to delete

eaa8d40

Can merge as level 6

Shift some code around

3e345a1

Shift some code around

86eff83

Merge branch 'temp' into Level-6

bc967b5

Merge tag 'Level-6'

3371288

Add Level-7

3ea3669

Merge with level 7 branch in future

Add jar file

94554ee

Revert "Add Level-7"

f143ba1

This reverts commit 3ea3669.

Merge commit '94554eeda815c2da603e1e0fbba5846a9b718994' into Level-7

2de3c38

Add level 7

e06c4e3

Add jar file

f56c210

exetr reviewed Sep 17, 2022

View reviewed changes

jjtoh and others added 3 commits September 28, 2022 22:01

Add more OOP

8e3a781

Add Level 9

9413857

Merge pull request #1 from jjtoh/Level-9

63c2c4a

Add Level 9

jjtoh and others added 4 commits September 29, 2022 01:01

Add JavaDoc

d0aba84

Repackaged some files

Merge pull request #2 from jjtoh/A-JavaDoc

62d50db

Add JavaDoc

Update README.md

9a13001

Update some code logic

bef3c36


		public class FileManager {

		private static Path taskDataPath = Paths.get(System.getProperty("user.dir"), "data", "tasks.txt");

Uh oh!

Conversation

jjtoh commented Aug 29, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Franky4566 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

exetr left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants