[Cheah Hao Yi] iP by CheahHaoYi · Pull Request #57 · nus-cs2113-AY2223S1/ip

CheahHaoYi · 2022-08-29T15:53:18Z

Added week 3 iP progress

dhanish265

Overall, I think it's quite good. Just need those minor edits that I suggested.

dhanish265 · 2022-09-02T03:39:14Z

 public class Duke {
-    public static void main(String[] args) {
+
+    public static Task[] tasks = new Task[100];


Please replace magic literal ('100'). Consider using a final value.

dhanish265 · 2022-09-02T03:42:19Z

+    public static Task[] tasks = new Task[100];
+    public static int numTasks = 0;
+
+    public static void listTasks(){


I think there should be a space between the closing bracket and open brace. You can use the reformat code option for the IDE to do it for you

dhanish265 · 2022-09-02T03:46:06Z

+        System.out.println("What can I do for you?");
+    }
+
+    public static boolean toExit(String userInput) {


can consider changing the method name to reflect the boolean nature of the method (toExit does not sound like it's a boolean method)

dhanish265 · 2022-09-02T03:48:38Z

+        System.out.println("Beep boop, now you have " + numTasks + " tasks");
+    }
+
+    public  static void addDeadline(String param){


perhaps it is accidental, but there are actually 2 spaces between 'public' and 'static' in this method and the next method

kaseykwok

Nice work. Hope my review could help.

kaseykwok · 2022-09-02T03:44:45Z

 public class Duke {
-    public static void main(String[] args) {
+
+    public static Task[] tasks = new Task[100];


Avoid using magic literals. Consider adding a constant for it.

kaseykwok · 2022-09-02T03:48:58Z

+        final String ERROR_OUT_OF_BOUND = "Sorry, the task does not seem to exist :<";
+        tasks[whichTask].setStatus(done);
+
+        if(whichTask > numTasks){


Consider adding spaces before the opening parenthesis and after the closing parenthesis.

kaseykwok · 2022-09-02T03:50:55Z

+        System.out.println("Beep boop, now you have " + numTasks + " tasks");
+    }
+
+    public  static void addDeadline(String param){


Avoid double spacing.

kaseykwok · 2022-09-02T03:52:24Z

+        */
+
+        final String LOGO = "\n" +
+        "     _________________________________________\n" +


Indentation for wrapped lines should be 8 spaces.

kaseykwok · 2022-09-02T03:53:45Z

+
+    public static void listTasks(){
+        System.out.println("Beep beep, listing out the tasks....Loading.....");
+        for(int i = 0; i < numTasks; i++){


Consider adding space before the opening parenthesis.

morbenami1

Over all great job, amazing code and very creative :)

morbenami1 · 2022-09-02T04:03:44Z

 public class Duke {
-    public static void main(String[] args) {
+
+    public static Task[] tasks = new Task[100];


use magic number

morbenami1 · 2022-09-02T04:05:15Z

+    }
+
+    public static void processUserInput(String userInput){
+        String[] splitInput = userInput.split(" ", 2);


instead of splitInput- inputSplitedBySpace

morbenami1 · 2022-09-02T04:08:36Z

+    private boolean isDone;
+    private String taskDescription;
+
+    private final String STATUS_DONE_ICON = "X";


gread job! adding the final String for the mark status

morbenami1 · 2022-09-02T04:10:10Z

-    public static void main(String[] args) {
+
+    public static Task[] tasks = new Task[100];
+    public static int numTasks = 0;


change to a more informative name

…andle errors

…ity to handle errors" This reverts commit 1f2180e.

sevenseasofbri

Hi Hao Yi, good job on the iP so far! I have added some comments on the code quality, coding standard violations and naming conventions. Hope they will be helpful. 👍🏽

sevenseasofbri · 2022-09-16T11:46:49Z

+
+    public static void greetUser() {
+
+        final String LOGO = "\n"


Consider moving the final variable to make it a global variable in this class.

sevenseasofbri · 2022-09-16T11:47:55Z

+        System.out.println(LOGO);
+        System.out.println("Hello! I'm Duke");
+        System.out.println("What can I do for you?");


Perhaps can avoid the usage of magic literals by declaring these as final variables in this class. (Same for line 64)

sevenseasofbri · 2022-09-16T11:49:10Z

+        System.out.println("What can I do for you?");
+    }
+
+    public static boolean isToExit(String userInput) {


Perhaps name this function isExit since it would be easier to understand at first glance.

sevenseasofbri · 2022-09-16T11:51:04Z

+            case ("list"): //Fallthrough
+            case ("mark"): //Fallthrough
+            case ("unmark"): //Fallthrough
+            case ("todo"): //Fallthrough
+            case ("deadline"): //Fallthrough


Perhaps remove the comment //Fallthrough since it is redundant. You can consider adding one fallthrough comment at the end of the case. (I see this in a couple of places, so do look into that)

sevenseasofbri · 2022-09-16T11:51:36Z

+                return false;
+        }
+    }
+    private boolean isCorrectInput(String[] parsed ) {


Consider adding at least a single line space between functions to improve readability

sevenseasofbri · 2022-09-16T11:52:32Z

+    }
+
+    private String[] parseParameter(String inputString, String optionFlag){
+        int OPTION_LEN = 4;


Naming conventions of regular variables is pascalCase. Consider using that here instead of all caps.

sevenseasofbri · 2022-09-16T11:55:32Z

+
+    public void parseUserInput(String userInput) throws UnknownCommandException, DukeException {
+
+        String[] inputSplitBySpace = userInput.split(" ", 2);


Do consider avoiding the usage of magic literals. Store and use the values as final variables instead

sevenseasofbri · 2022-09-16T11:56:25Z

+    public void parseUserInput(String userInput) throws UnknownCommandException, DukeException {
+
+        String[] inputSplitBySpace = userInput.split(" ", 2);
+        //assume first word input by user is the command


Bring this comment closer to right above the line it describes, so it is clear as to what you are talking about

sevenseasofbri · 2022-09-16T11:58:23Z

+public class TaskManager {
+
+    private static final int RESIZE_FACTOR = 2;
+    private static int NUM_TASK;


Please follow the naming conventions for regular variables. It should be pascalCase for this one since it is not a final variable

# Conflicts: # src/main/java/Duke/InputParser.java

Create Jar file # Conflicts: # src/main/java/Duke/TaskManager.java

Add new exceptions Refactor Exception using Inheritance

Init class for Level 8

Refactor some functions from Duke class into utilities classes

Refactor functionalities more clearly into the utility classes

Add exception check for wrong option flag Add find functionality

Level 9, Week 7 iP task: Find

To push A-MoreOOP tag onto github (missed out earlier)

To create branch for A-JavaDoc (missed out earlier)

Fix minor coding style violations

Fix parser bug for bad option flags Refactor to replace hardcoded line seperator with java system line separator

CheahHaoYi added 6 commits August 22, 2022 01:37

Add greet user functionality

eaa2aaf

Add Greet, Echo user and Exit functionality

433b453

add adding-task and listing task functionality

eb827dc

created task class, add mark/unmark task functionality

f9fd1fb

refactored Duke and Task class

fb9eaba

Added ToDos, Events and Deadline classes

aab7e9e

dhanish265 reviewed Sep 2, 2022

View reviewed changes

kaseykwok reviewed Sep 2, 2022

View reviewed changes

morbenami1 reviewed Sep 2, 2022

View reviewed changes

CheahHaoYi added 12 commits September 4, 2022 03:45

Refactoring, adjusted spacing on methods and if-else clauses

3742f1b

Add text UI test, expected.txt and edit the UI in Duke

d2f2551

Add InputParser, TaskManager Class, Exceptions and functionality to h…

1f2180e

…andle errors

Revert "Add InputParser, TaskManager Class, Exceptions and functional…

e0363c8

…ity to handle errors" This reverts commit 1f2180e.

Change programme exit string

6d79366

test merging

d9321d2

Merge branch 'branch-Level-5'

3b8521c

Re-add additional class and exception after merging

8de836e

Package all java files

96cd84e

Change implementation of Tasks from array to arrayList

e8391eb

Add delete functionality

f69da6c

Extra Commit for branch test

620ffda

sevenseasofbri reviewed Sep 16, 2022

View reviewed changes

CheahHaoYi added 8 commits September 16, 2022 20:22

Added save functionality

7155402

Merge branch 'branch-Level-6'

37a8a94

# Conflicts: # src/main/java/Duke/InputParser.java

Merge branch 'branch-Level-7'

7a1cc50

Create Jar file # Conflicts: # src/main/java/Duke/TaskManager.java

Address CS2113 TA mid-term comment

667eb9a

Reorganize Exception classes

5ca178b

Add new exceptions Refactor Exception using Inheritance

Refactor packages

a81150f

Init class for Level 8

Change utiliti classes to static references

a3d18d3

Refactor some functions from Duke class into utilities classes

Fix the bug to remove redundant commands stored in data file

ff60b2d

CheahHaoYi and others added 16 commits September 30, 2022 01:55

Add Command class

b54fa9a

Refactor functionalities more clearly into the utility classes

Attempt to use hashset to implement find functionality

7666660

Rename parser and tasklist

c881119

Add exception check for wrong option flag Add find functionality

Add find functionality

7f63388

Merge pull request #1 from CheahHaoYi/branch-Level-9

5bf5380

Level 9, Week 7 iP task: Find

Add JavaDoc

bee95f8

Add help functionality, user guide draft

12fbdeb

Polish up user guide, Fix ArrayOutOfBoudException for Delete

7ece7bf

Update test input and expected output

6059848

Minor Edits to JavaDoc

be01be8

To push A-MoreOOP tag onto github (missed out earlier)

Fix minor coding style violations

ee9bc5d

To create branch for A-JavaDoc (missed out earlier)

Merge pull request #2 from CheahHaoYi/branch-A-JavaDoc

82cb255

Fix minor coding style violations

update readme.md

ba2c021

fix format error on Readme

d46a13f

Fix check bug

b2d6236

Fix parser bug for delete, mark, unmark

659bfdf

Fix parser bug for bad option flags Refactor to replace hardcoded line seperator with java system line separator


		public void parseUserInput(String userInput) throws UnknownCommandException, DukeException {

		String[] inputSplitBySpace = userInput.split(" ", 2);

Uh oh!

Conversation

CheahHaoYi commented Aug 29, 2022

Uh oh!

dhanish265 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kaseykwok left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

morbenami1 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sevenseasofbri left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants