[Xinran] iP by striris · Pull Request #86 · nus-cs2113-AY2122S2/ip

striris · 2022-02-03T16:06:54Z

No description provided.

Add the ability to mark tasks as done. Optionally, add the ability to change the status back to not done.

Add support for tracking three types of tasks: ToDos: tasks without any date/time attached to it e.g., visit new theme park Deadlines: tasks that need to be done before a specific date/time e.g., submit report by 11/10/2019 5pm Events: tasks that start at a specific time and ends at a specific time e.g., team project meeting on 2/10/2019 2-4pm

bbawj · 2022-02-04T02:48:46Z

+    }
+}
+
+//this.description = description.substring(0, description.lastIndexOf("/") + 4);


Your files should end with a newline!

bbawj · 2022-02-04T02:49:37Z

+                System.out.println(bye);
+                break;
+            }
+            else if(userInput.equals("list")){//show list


Your comments should be above the line you are commenting

Thanks for the reminder! I will make corresponding changes.

bbawj · 2022-02-04T02:50:09Z

+                for(int i = 0; i<count ; i++)
+                    System.out.println(i+1 + "." + tasks[i]);
+            }
+            else if(userInput.split(" ")[0].equals("mark")){//mark task


under the coding standards, your else if should be written right next to the bracket above

I see. Didn't notice that! thanks:)

chihyingho

Good effort! :)

chihyingho · 2022-02-04T02:47:05Z

            }
-            else if(input.equals("list")){
+            else if(userInput.equals("list")){//show list
                System.out.println("Here are the tasks in your list:");


Perhaps you could wrap your list function in a method? Additionally, I think the comment can be indented relative to its position in the code (I noticed this in other parts of the code) :)

Thanks for the reminder! I will make corresponding changes.

chihyingho · 2022-02-04T02:50:07Z

+                    System.out.println(i+1 + "." + tasks[i]);
            }
-            else if(input.split(" ")[0].equals("mark")){
+            else if(userInput.split(" ")[0].equals("mark")){//mark task


Perhaps you can consider using a boolean to reduce the complexity of this if condition? I think this can apply for the other if conditions within this while loop :)

that's a good idea!

chihyingho · 2022-02-04T02:50:43Z

                //get the integer k in the string
                System.out.println("Nice! I've marked this task as done:");
-                int k = Integer.parseInt(input.split(" ")[1]);
+                int k = Integer.parseInt(userInput.split(" ")[1]);


Perhaps you can consider renaming the variable name k with a different name that brings across what k represents?

That has a point:) thanks for the suggestion.

ElaineQT

Maybe some parts can be refactored, but generally the code is clear and compact. Good job!

ElaineQT · 2022-02-04T02:55:27Z

-                + "| |_| | |_| |   <  __/\n"
-                + "|____/ \\__,_|_|\\_\\___|\n";
-        System.out.println("Hello from\n" + logo);
+        Task[] tasks = new Task[100];


Perhaps the "100" should be set as a constant?

ElaineQT · 2022-02-04T02:59:33Z

+                String toDoDescription = userInput.split("todo")[1].trim();
+                Task t = new ToDo(toDoDescription);
+                tasks[count] = t;
+                count++;
+                System.out.println("Got it! I've added this task: ");
+                System.out.println(t);
+                System.out.println("Now you have " + count + " tasks in the list.");


Would it be better to extract this part as a method? Similarly for adding deadlines and events.

ok! that makes sense.

ElaineQT · 2022-02-04T03:02:02Z

+                System.out.println("Got it! I've added this task: ");
+                System.out.println(d);
+                System.out.println("Now you have " + count + " tasks in the list.");


This printing part is used repeatedly. Maybe it can be written as a separate method so that it can be reused.

sure, I think that would be better also.

ElaineQT · 2022-02-04T03:10:09Z

+        String by = new String();
+        String at = new String();


These two variables are used only in certain situations. Maybe you can consider adding some utility methods?
References: https://refactoring.guru/smells/temporary-field

ok I will take a look at this.

…methods.

Mick609

Clean code with some naming convention issues.

Mick609 · 2022-03-01T02:53:28Z

+
+    private static ArrayList<Task> tasks = new ArrayList<>();
+
+    private static void greeting() {


Maybe you should consider using a verb as the name of a method, like "greet"?

Mick609 · 2022-03-01T02:55:09Z

+                + "What can I do for you?\n"
+                + "----------------------------------------------\n";
+        String bye = "Bye. Hope to see you again soon!\n";
+        System.out.println(greeting);


I assume you would want to print the String bye here?

Mick609 · 2022-03-01T02:55:56Z

+        System.out.println(tasks.get(taskIndex-1));
+    }
+
+    private static void addTask(Task t) {


Maybe you can use a more descriptive name for the argument, like "task"?

Mick609 · 2022-03-01T02:56:42Z

+    }
+
+    private static void startBot() {
+        Scanner sc = new Scanner(System.in);


Maybe you can name the Scanner as "scanner"?

Mick609 · 2022-03-01T02:57:42Z

+            }
+            else if(choice.equals("todo")) {
+                String toDoDescription = userInput.split("todo")[1].trim();
+                Task t = new ToDo(toDoDescription);


Maybe you can use a name like "task" for the object?

…o get user input.

Level-9: Give users a way to find a task by searching for a keyword. used Ui t…

…tatement error bug by try and catch block.

…mand.

striris added 6 commits February 3, 2022 17:19

Level-0 Greeting

fc8a985

Level 1. Greet, Echo, Exit

14b2a53

Level 2. Add, List

6e9acc1

deleted unnecessary package.

96dc870

Level 3. Mark as Done

91a1e1d

Add the ability to mark tasks as done. Optionally, add the ability to change the status back to not done.

bbawj reviewed Feb 4, 2022

View reviewed changes

chihyingho reviewed Feb 4, 2022

View reviewed changes

ElaineQT reviewed Feb 4, 2022

View reviewed changes

striris added 7 commits February 18, 2022 10:34

add a new line at the end of file

c1137e8

Merge branch 'branch-Level-5'

b1e49b1

created a package

409d603

created the jar file

3a3855f

changed array to ArrayList<Task>. added deletion function. extracted …

315b905

…methods.

Merge branch 'branch-Level-6'

0d2eeca

added saveTasks function to convert the list into a text file.

7632f81

Mick609 reviewed Mar 1, 2022

View reviewed changes

striris and others added 13 commits March 2, 2022 12:19

added load/save file functions. organized tasks into a package.

b18486b

A-MoreOOP added TaskList, changed FileManager to Storage, Added Ui.

94aca1f

Give users a way to find a task by searching for a keyword. used Ui t…

c04f768

…o get user input.

Merge pull request #1 from striris/branch-Level-9

12a5cb3

Level-9: Give users a way to find a task by searching for a keyword. used Ui t…

Added Java doc.

a583454

Added User Guide in README.md

0ada8a3

Set theme jekyll-theme-dinky

d5cfae6

code quality

d37e926

Merge branch 'master' of https://github.com/striris/ip

b15dc81

deleted Main class because it's reductant.

b86f4ab

minor changes

2b642be

modified user guide

b10c45c

added try and catch

d497326

striris added 6 commits March 22, 2022 22:47

Used Ui to print error messages.

0198f4c

change if statement to switch statement and fixed the event without s…

6204347

…tatement error bug by try and catch block.

Modified the code such that the file will get updated after every Com…

64fc037

…mand.

Added more JavaDoc for functions and classes

7da23ce

Fixed number format bug for delete and mark function.

18e39e7

Made it compulsary to have description for each task.

ae479ff


		private static ArrayList<Task> tasks = new ArrayList<>();

		private static void greeting() {

Uh oh!

Conversation

striris commented Feb 3, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chihyingho left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ElaineQT left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Mick609 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants