[Timothy Chang] iP by timchang27 · Pull Request #82 · nus-cs2113-AY2122S2/ip

timchang27 · 2022-02-03T09:11:52Z

No description provided.

yuhaochua · 2022-02-04T02:36:06Z

@@ -0,0 +1,17 @@
+public class Deadline extends Task {
+    protected String ddate;


Maybe could use a more descriptive name for this? For example dueDate instead of just ddate.

yuhaochua · 2022-02-04T02:36:50Z

@@ -1,10 +1,104 @@
+import java.util.*;


Maybe you could import just the ArrayList instead of everything from the Java util library?

yuhaochua · 2022-02-04T02:38:33Z

@@ -0,0 +1,16 @@
+public class Event extends Task{
+    protected String edate;


Same as previous comment, maybe could use more specific variable name?

yuhaochua · 2022-02-04T02:39:00Z

+public class Task {
+
+    protected String description;
+    protected boolean isTaskDone;


I like the naming of this boolean variable, it is clear what it is representing.

yuhaochua · 2022-02-04T02:41:26Z

+        this.isTaskDone = isTaskDone;
+    }
+
+    public String getDescription(){


I like how you follow the Java coding standards and stuck with K&R brackets, as well as writing your methods in camelCase

Nineves

Good job! Some details may be improved.

mathanmahe · 2022-02-04T02:56:11Z

                + "| |_| | |_| |   <  __/\n"
                + "|____/ \\__,_|_|\\_\\___|\n";
+
+        ArrayList<Task> tasks = new ArrayList<Task>();


Like the use of dynamic ArrayList

mathanmahe · 2022-02-04T02:57:27Z

+                    System.out.println(tasks.get(index - 1).getDescription());
                }
            }
+            else if(userInput.startsWith("todo")){


Clean code, could think about refactoring the statements into functions to demonstrate SLAP.

mathanmahe · 2022-02-04T02:58:32Z

@@ -0,0 +1,17 @@
+public class Deadline extends Task {
+    protected String ddate;


I also think dueDate is a better variable name

xseh

Good attempt! Do take note of the Java coding standards and improve code readability with more SLAP.

xseh · 2022-02-16T10:23:50Z

+import java.util.*;
+import java.lang.*;


According to the Java standard code,

Imported classes should always be listed explicitly.

xseh · 2022-02-16T10:25:54Z

+    public static void main(String[] args) throws IndexOutOfBoundsException {
+
+        Scanner sc = new Scanner(System.in);
+        DukeException ex = new DukeException();
+
+        String logo = " ____        _        \n"
+                + "|  _ \\ _   _| | _____ \n"
+                + "| | | | | | | |/ / _ \\\n"
+                + "| |_| | |_| |   <  __/\n"
+                + "|____/ \\__,_|_|\\_\\___|\n";
+
+        ArrayList<Task> tasks = new ArrayList<Task>();
+
+        System.out.println("Hello from\n" + logo);
+        System.out.println("Hello! I'm Duke.Duke\n" + "What can I do for you?");
+        displayOptions();
+        String userInput;
+        do {
+            userInput = sc.nextLine();
+            if(userInput.equals("list")){
+                System.out.println("-------------------------------------------------------------------------\n" + "Here are the tasks in your list:");
+
+                int i=1;
+                for(Task task: tasks){
+                    System.out.println(i + ": " + task.getDescription());
+                    i++;
+                }
+                i=0;
+                System.out.println("-------------------------------------------------------------------------");
+            }
+            else if(userInput.equals("bye")){
+                break;
+            }
+            else if(userInput.startsWith("mark")){
+                String[] input = new String[10];
+                input  = userInput.split(" ");
+                int index = Integer.parseInt(input[1]); //index of task to be marked
+                if(tasks.get(index-1).getTaskStatus() == true){
+                    System.out.println("The task is already marked!");
+                    System.out.println("-------------------------------------------------------------------------");
+                }
+                else{
+                    tasks.get(index-1).setMark();
+                    System.out.println("-------------------------------------------------------------------------\n" + "Nice! I've marked this task as done: ");
+                    System.out.println(tasks.get(index-1).getDescription());
+                }
+            }
+            else if(userInput.startsWith("unmark")){
+                String[] input = new String[10];
+                input  = userInput.split(" ");
+                int index = Integer.parseInt(input[1]); //index of task to be unmarked
+                if(tasks.get(index-1).getTaskStatus()==false){
+                    System.out.println("The task is not completed yet!");
+                    System.out.println("-------------------------------------------------------------------------");
+                }
+                else {
+                    tasks.get(index - 1).setUnmark();
+                    System.out.println("-------------------------------------------------------------------------\n" + "OK, I've marked this task as not done yet:");
+                    System.out.println(tasks.get(index - 1).getDescription());
+                }
+            }
+            else if(userInput.startsWith("todo")){
+                try{
+                    String newtodo = userInput.split("todo")[1].trim();
+                    Todo newTodo = new Todo(newtodo);
+                    tasks.add(newTodo);
+                    System.out.println("-------------------------------------------------------------------------");
+                    System.out.println("Got it! I've added this task: " + newTodo.getDescription());
+                    System.out.println("Now you have " + tasks.size() + " tasks in the list.");
+                } catch(IndexOutOfBoundsException e){
+                    ex.missingDescription("todo");
+                } finally{
+                    System.out.println("What else should I do for you?");
+                }
+            }
+            else if(userInput.startsWith("deadline")){
+                try{
+                    String[] input = userInput.split("/by");
+                    String ddate = input[1].trim();
+                    String deadline = input[0].split("deadline")[1].trim();
+                    Deadline newDeadline = new Deadline(deadline, ddate);
+                    tasks.add(newDeadline);
+                    System.out.println("-------------------------------------------------------------------------");
+                    System.out.println("Got it! I've added this task: ");
+                    System.out.println(newDeadline.getDescription());
+                    System.out.println("Now you have " + tasks.size() + " tasks in the list.");
+                } catch(IndexOutOfBoundsException e){
+                    ex.missingDescription("deadline");
+                } finally{
+                    System.out.println("What else should I do for you?");
+                }
+            }
+            else if(userInput.startsWith("event")){
+                try{
+                    String[] input = userInput.split("/at");
+                    String eventDate = input[1].trim();
+                    String event = input[0].split("event")[1].trim();
+                    Event newEvent = new Event(event, eventDate);
+                    tasks.add(newEvent);
+                    System.out.println("-------------------------------------------------------------------------");
+                    System.out.println("Got it! I've added this task: ");
+                    System.out.println(newEvent.getDescription());
+                    System.out.println("Now you have " + tasks.size() + " tasks in the list.");
+                } catch(IndexOutOfBoundsException e){
+                    ex.missingDescription("event");
+                } finally{
+                    System.out.println("What else should I do for you?");
+                }
+            }
+            else{
+                Task newTask = new Task(userInput);
+                tasks.add(newTask);
+                System.out.println("added: "+ userInput);
+            }
+        }while(!userInput.equals("bye"));
+
+        System.out.println("Bye. Hope to see you again soon!");
+    }


Avoid long methods (> 30 LoCs). Consider refactoring and SLAP to improve code readability.

xseh · 2022-02-16T10:27:01Z

+        do {
+            userInput = sc.nextLine();
+            if(userInput.equals("list")){
+                System.out.println("-------------------------------------------------------------------------\n" + "Here are the tasks in your list:");


Avoid magic literals. Consider putting the constants into variables. For example, "-------------------------------------------------------------------------\n" can be declared as MESSAGE_BORDER.

xseh · 2022-02-16T10:29:20Z

+                    System.out.println(i + ": " + task.getDescription());
+                    i++;
+                }
+                i=0;


Avoid magic numbers. If the value is an iterator, consider putting into a for loop instead.

xseh · 2022-02-16T10:31:48Z

+            }
+            else if(userInput.equals("bye")){


According to the Java coding standard, the if-else statements should resemble:

if (condition) { statements; } else if (condition) { statements; } else { statements; }

xseh · 2022-02-16T10:33:38Z

+                String[] input = new String[10];
+                input  = userInput.split(" ");
+                int index = Integer.parseInt(input[1]); //index of task to be marked
+                if(tasks.get(index-1).getTaskStatus() == true){


Avoid complicated expressions. Consider refactoring the expressions into different methods.

xseh · 2022-02-16T10:35:43Z

+            else if(userInput.startsWith("mark")){
+                String[] input = new String[10];
+                input  = userInput.split(" ");
+                int index = Integer.parseInt(input[1]); //index of task to be marked


Avoid magic numbers. Instead of a comment, consider declaring a variable for the integers (e.g. INDEX_MARK_TASK)

xseh · 2022-02-16T10:37:06Z

+                }
+                else {
+                    tasks.get(index - 1).setUnmark();
+                    System.out.println("-------------------------------------------------------------------------\n" + "OK, I've marked this task as not done yet:");


According to the Java coding standard,

Line length should be no longer than 120 chars.
If the line exceeds the limit, use line wrapping at appropriate places of the line.

xseh · 2022-02-16T10:39:12Z

+                    String[] input = userInput.split("/by");
+                    String ddate = input[1].trim();
+                    String deadline = input[0].split("deadline")[1].trim();
+                    Deadline newDeadline = new Deadline(deadline, ddate);
+                    tasks.add(newDeadline);
+                    System.out.println("-------------------------------------------------------------------------");
+                    System.out.println("Got it! I've added this task: ");
+                    System.out.println(newDeadline.getDescription());
+                    System.out.println("Now you have " + tasks.size() + " tasks in the list.");


Consider further SLAP to improve code readability.

xseh · 2022-02-16T10:41:57Z

+package duke;
+
+public class DukeException extends Exception {
+    public void missingDescription(String command){


According to the Java coding standard, there should be a whitespace between the brackets ){.

New README

timchang27 added 5 commits January 27, 2022 23:10

Greet for Duke

1c143ba

Greet, Echo, Exit for Duke

8931863

Week 3 IP

2f45497

Week 3 IP

97529e9

Week 4 IP: Todo, Deadline, Event

ad53131

yuhaochua reviewed Feb 4, 2022

View reviewed changes

Nineves reviewed Feb 4, 2022

View reviewed changes

mathanmahe reviewed Feb 4, 2022

View reviewed changes

Week 5: Added Exception Handlers

530e642

xseh reviewed Feb 16, 2022

View reviewed changes

timchang27 and others added 6 commits February 17, 2022 22:29

Week 6: Implement Delete and Save

62d9872

Week 7: Implement Save

d835cf7

Week 7: Implement Save

bf0e784

Week 7: MoreOOP

8aea02d

Set theme jekyll-theme-slate

3b40cec

Update README.md

d25130e

New README

		@@ -0,0 +1,17 @@
		public class Deadline extends Task {
		protected String ddate;

		@@ -0,0 +1,16 @@
		public class Event extends Task{
		protected String edate;

Uh oh!

Conversation

timchang27 commented Feb 3, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Nineves left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xseh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants