Skip to content

[Test]: cover daily reminder formatting - #82

Merged
viiccwen merged 1 commit into
mainfrom
test/daily-reminder-formatting-19
Jul 8, 2026
Merged

[Test]: cover daily reminder formatting#82
viiccwen merged 1 commit into
mainfrom
test/daily-reminder-formatting-19

Conversation

@viiccwen

@viiccwen viiccwen commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Summary

Add focused unit tests for daily reminder pure logic, covering recipient filtering, event date matching, and reminder message formatting for single and multiple events.

Related Issue

Fixes #19

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Configuration or deployment
  • Tests

Changes

  • Expanded reminder recipient filtering coverage for expired, unsubscribed, unbound, and Discord-subscribed members.
  • Added date-matching assertions for course rows and placeholder cleanup.
  • Added reminder formatting tests for single events, multiple events, combined flags, and empty optional fields.

Testing

  • Local tests or checks pass
  • Manual verification completed
  • Not tested; reason:

Commands run:

uv run pytest tests/domain/test_reminders.py
make test
make precommit

Impact Checklist

  • Discord bot behavior checked, if affected
  • MCP server behavior checked, if affected
  • Webhook behavior checked, if affected
  • Docker or compose changes checked, if affected
  • Environment variables documented, if changed
  • Logs do not expose secrets or sensitive data

Notes for Reviewers

These tests exercise only ian.domain.reminders pure functions. They do not send Discord messages, call platform APIs, or read real member data files.

@viiccwen
viiccwen merged commit 7506c91 into main Jul 8, 2026
2 checks passed
@viiccwen
viiccwen deleted the test/daily-reminder-formatting-19 branch July 8, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Add unit tests for daily reminder formatting

1 participant